From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anjZh-0007cM-FT for qemu-devel@nongnu.org; Wed, 06 Apr 2016 05:16:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anjZg-00028t-Nv for qemu-devel@nongnu.org; Wed, 06 Apr 2016 05:16:33 -0400 From: "Daniel P. Berrange" Date: Wed, 6 Apr 2016 10:16:18 +0100 Message-Id: <1459934178-6142-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH] qemu-img: fix formatting of error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org The error_reportf_err() will not automatically append a ': ' before adding its suffix, so we must include that in the message we pass it, otherwise we get a badly formatted message lacking whitespace: qemu-img: Could not open 'driver=nbd,host=127.0.0.1,port=6666,tls-creds=tls0'Failed to connect socket: Connection refused Signed-off-by: Daniel P. Berrange --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 06264d9..17c5cfd 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -256,7 +256,7 @@ static BlockBackend *img_open_opts(const char *optstr, options = qemu_opts_to_qdict(opts, NULL); blk = blk_new_open(NULL, NULL, options, flags, &local_err); if (!blk) { - error_reportf_err(local_err, "Could not open '%s'", optstr); + error_reportf_err(local_err, "Could not open '%s': ", optstr); return NULL; } blk_set_enable_write_cache(blk, !writethrough); -- 2.5.5