[Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup

[Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup

[marcandre.lureau]

From: Marc-André Lureau <marcandre.lureau@redhat.com>

The following 2 one-liners remove the chardev from the vhost-user
netdev it is attached to. This prevents from further reuse of the
chardev that would likely fail to setup again with the slave.

Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1256619
https://bugzilla.redhat.com/show_bug.cgi?id=1256618

rfc->v1:
- rfc was sent a few months ago, no comments: rebased & resend as
  non-rfc this time.

Marc-André Lureau (2):
  vhost-user: release chardev on cleanup
  vhost-user: delete chardev on cleanup

 net/vhost-user.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.5.5

[Qemu-devel] [PATCH 1/2] vhost-user: release chardev on cleanup

[marcandre.lureau]

From: Marc-André Lureau <marcandre.lureau@redhat.com>

On init, vhost-user does qemu_chr_fe_claim_no_fail(). Do the opposite on
cleanup to allow removing or reusing the chardev.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 net/vhost-user.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/vhost-user.c b/net/vhost-user.c
index 1b9e73a..29fe097 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -142,6 +142,8 @@ static void vhost_user_cleanup(NetClientState *nc)
     }
 
     qemu_purge_queued_packets(nc);
+
+    qemu_chr_fe_release(s->chr);
 }
 
 static bool vhost_user_has_vnet_hdr(NetClientState *nc)
-- 
2.5.5

[Qemu-devel] [PATCH 2/2] vhost-user: delete chardev on cleanup

[marcandre.lureau]

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Remove the chardev implicitely when cleaning up the netdev. This
prevents from reusing the chardev since it would be in an incorrect
state with the slave.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 net/vhost-user.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/vhost-user.c b/net/vhost-user.c
index 29fe097..2d7271a 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -144,6 +144,7 @@ static void vhost_user_cleanup(NetClientState *nc)
     qemu_purge_queued_packets(nc);
 
     qemu_chr_fe_release(s->chr);
+    qemu_chr_delete(s->chr);
 }
 
 static bool vhost_user_has_vnet_hdr(NetClientState *nc)
-- 
2.5.5

Re: [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup

[Marc-André Lureau]

ping

On Wed, Apr 6, 2016 at 5:38 PM,  <marcandre.lureau@redhat.com> wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The following 2 one-liners remove the chardev from the vhost-user
> netdev it is attached to. This prevents from further reuse of the
> chardev that would likely fail to setup again with the slave.
>
> Related to:
> https://bugzilla.redhat.com/show_bug.cgi?id=1256619
> https://bugzilla.redhat.com/show_bug.cgi?id=1256618
>
> rfc->v1:
> - rfc was sent a few months ago, no comments: rebased & resend as
>   non-rfc this time.
>
> Marc-André Lureau (2):
>   vhost-user: release chardev on cleanup
>   vhost-user: delete chardev on cleanup
>
>  net/vhost-user.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> --
> 2.5.5
>



-- 
Marc-André Lureau

Re: [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup

[Marc-André Lureau]

Hi

On Thu, Jun 16, 2016 at 1:05 PM Marc-André Lureau <
marcandre.lureau@gmail.com> wrote:

> ping
>

2nd ping, probably for-2.8 now


>
> On Wed, Apr 6, 2016 at 5:38 PM,  <marcandre.lureau@redhat.com> wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > The following 2 one-liners remove the chardev from the vhost-user
> > netdev it is attached to. This prevents from further reuse of the
> > chardev that would likely fail to setup again with the slave.
> >
> > Related to:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1256619
> > https://bugzilla.redhat.com/show_bug.cgi?id=1256618
> >
> > rfc->v1:
> > - rfc was sent a few months ago, no comments: rebased & resend as
> >   non-rfc this time.
> >
> > Marc-André Lureau (2):
> >   vhost-user: release chardev on cleanup
> >   vhost-user: delete chardev on cleanup
> >
> >  net/vhost-user.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > --
> > 2.5.5
> >
>
>
>
> --
> Marc-André Lureau
>
-- 
Marc-André Lureau

Re: [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup

[Marc-André Lureau]

Hi

On Thu, Aug 11, 2016 at 1:16 PM Marc-André Lureau <
marcandre.lureau@gmail.com> wrote:

> Hi
>
> On Thu, Jun 16, 2016 at 1:05 PM Marc-André Lureau <
> marcandre.lureau@gmail.com> wrote:
>
>> ping
>>
>
> 2nd ping, probably for-2.8 now
>

3rd ping, those are 2 one-liners, don't be shy :)

thanks
-- 
Marc-André Lureau

Re: [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup

[Marc-André Lureau]

Hi

On Tue, Sep 27, 2016 at 1:44 PM Marc-André Lureau <
marcandre.lureau@gmail.com> wrote:

> Hi
>
> On Thu, Aug 11, 2016 at 1:16 PM Marc-André Lureau <
> marcandre.lureau@gmail.com> wrote:
>
> Hi
>
> On Thu, Jun 16, 2016 at 1:05 PM Marc-André Lureau <
> marcandre.lureau@gmail.com> wrote:
>
> ping
>
>
> 2nd ping, probably for-2.8 now
>
>
> 3rd ping, those are 2 one-liners, don't be shy :)
>
>
Michael, could you look and pick those 2 patches?

thanks
-- 
Marc-André Lureau