From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anrhj-0000Y7-NM for qemu-devel@nongnu.org; Wed, 06 Apr 2016 13:57:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anrhi-0006Sh-Vr for qemu-devel@nongnu.org; Wed, 06 Apr 2016 13:57:23 -0400 From: Max Reitz Date: Wed, 6 Apr 2016 19:57:07 +0200 Message-Id: <1459965434-21531-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1459965434-21531-1-git-send-email-mreitz@redhat.com> References: <1459965434-21531-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Kevin Wolf , Alberto Garcia , qemu-devel@nongnu.org, Max Reitz bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS before invoking bdrv_open() on that BDS. This is probably a relict from when it used to do some modifications on that empty BDS, but now that is unnecessary, so we can just set bs_snapshot to NULL and let bdrv_open() do the rest. Signed-off-by: Max Reitz --- block.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block.c b/block.c index 1be887a..b6a452a 100644 --- a/block.c +++ b/block.c @@ -1472,8 +1472,7 @@ static int bdrv_append_temp_snapshot(BlockDriverState *bs, int flags, qdict_put(snapshot_options, "driver", qstring_from_str("qcow2")); - bs_snapshot = bdrv_new(); - + bs_snapshot = NULL; ret = bdrv_open(&bs_snapshot, NULL, NULL, snapshot_options, flags, &local_err); snapshot_options = NULL; -- 2.8.0