From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ansCb-0007cq-OW for qemu-devel@nongnu.org; Wed, 06 Apr 2016 14:29:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ansCa-0006xm-JZ for qemu-devel@nongnu.org; Wed, 06 Apr 2016 14:29:17 -0400 From: Max Reitz Date: Wed, 6 Apr 2016 20:28:45 +0200 Message-Id: <1459967330-4573-10-git-send-email-mreitz@redhat.com> In-Reply-To: <1459967330-4573-1-git-send-email-mreitz@redhat.com> References: <1459967330-4573-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v3 09/14] block/nbd: Use SocketAddress options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Kevin Wolf , Markus Armbruster , qemu-devel@nongnu.org, Max Reitz , Paolo Bonzini , Luiz Capitulino Drop the use of legacy options in favor of the SocketAddress representation, even for internal use (i.e. for storing the result of the filename parsing). Signed-off-by: Max Reitz --- block/nbd.c | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 9ae66ba..82dcb5e 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -89,9 +89,13 @@ static int nbd_parse_uri(const char *filename, QDict *options) ret = -EINVAL; goto out; } - qdict_put(options, "path", qstring_from_str(qp->p[0].value)); + qdict_put(options, "address.type", qstring_from_str("unix")); + qdict_put(options, "address.data.path", + qstring_from_str(qp->p[0].value)); } else { QString *host; + char *port_str; + /* nbd[+tcp]://host[:port]/export */ if (!uri->server) { ret = -EINVAL; @@ -106,12 +110,12 @@ static int nbd_parse_uri(const char *filename, QDict *options) host = qstring_from_str(uri->server); } - qdict_put(options, "host", host); - if (uri->port) { - char* port_str = g_strdup_printf("%d", uri->port); - qdict_put(options, "port", qstring_from_str(port_str)); - g_free(port_str); - } + qdict_put(options, "address.type", qstring_from_str("inet")); + qdict_put(options, "address.data.host", host); + + port_str = g_strdup_printf("%d", uri->port ?: NBD_DEFAULT_PORT); + qdict_put(options, "address.data.port", qstring_from_str(port_str)); + g_free(port_str); } out: @@ -188,7 +192,8 @@ static void nbd_parse_filename(const char *filename, QDict *options, /* are we a UNIX or TCP socket? */ if (strstart(host_spec, "unix:", &unixpath)) { - qdict_put(options, "path", qstring_from_str(unixpath)); + qdict_put(options, "address.type", qstring_from_str("unix")); + qdict_put(options, "address.data.path", qstring_from_str(unixpath)); } else { InetSocketAddress *addr = NULL; @@ -197,8 +202,9 @@ static void nbd_parse_filename(const char *filename, QDict *options, goto out; } - qdict_put(options, "host", qstring_from_str(addr->host)); - qdict_put(options, "port", qstring_from_str(addr->port)); + qdict_put(options, "address.type", qstring_from_str("inet")); + qdict_put(options, "address.data.host", qstring_from_str(addr->host)); + qdict_put(options, "address.data.port", qstring_from_str(addr->port)); qapi_free_InetSocketAddress(addr); } @@ -528,10 +534,12 @@ static void nbd_refresh_filename(BlockDriverState *bs, QDict *options) } } else { if (path) { - qdict_put(opts, "path", qstring_from_str(path)); + qdict_put(opts, "address.type", qstring_from_str("unix")); + qdict_put(opts, "address.data.path", qstring_from_str(path)); } else { - qdict_put(opts, "host", qstring_from_str(host)); - qdict_put(opts, "port", qstring_from_str(port)); + qdict_put(opts, "address.type", qstring_from_str("inet")); + qdict_put(opts, "address.data.host", qstring_from_str(host)); + qdict_put(opts, "address.data.port", qstring_from_str(port)); } } if (export) { -- 2.8.0