From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Thomas Huth" <thuth@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 17/21] hw/misc/sga: Use the correct ISA include
Date: Tue, 29 May 2018 10:58:05 +0300 [thread overview]
Message-ID: <145a7511-f2f9-6535-9711-8614a2ec16f1@gmail.com> (raw)
In-Reply-To: <20180528232719.4721-18-f4bug@amsat.org>
On 05/29/2018 02:27 AM, Philippe Mathieu-Daudé wrote:
> The SGA BIOS loader is an ISA device, it does not require the PCI header.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/misc/sga.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/sga.c b/hw/misc/sga.c
> index 97fd63f176..4a22a52a60 100644
> --- a/hw/misc/sga.c
> +++ b/hw/misc/sga.c
> @@ -25,7 +25,7 @@
> *
> */
> #include "qemu/osdep.h"
> -#include "hw/pci/pci.h"
> +#include "hw/isa/isa.h"
> #include "hw/loader.h"
> #include "sysemu/sysemu.h"
>
Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>
Thanks,
Marcel
next prev parent reply other threads:[~2018-05-29 7:58 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 23:26 [Qemu-devel] [PATCH v4 00/21] Includes cleanup Philippe Mathieu-Daudé
2018-05-28 23:26 ` [Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file Philippe Mathieu-Daudé
2018-05-28 23:48 ` Alex Williamson
2018-05-29 0:06 ` Michael S. Tsirkin
2018-05-29 0:36 ` Philippe Mathieu-Daudé
2018-05-29 9:53 ` Cornelia Huck
2018-05-29 10:45 ` Paolo Bonzini
2018-05-29 13:09 ` Alex Williamson
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 02/21] accel: Do not include "exec/address-spaces.h" if it is not necessary Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 03/21] target: " Philippe Mathieu-Daudé
2018-05-29 10:05 ` Cornelia Huck
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 04/21] memory: Do not include "exec/ioport.h" " Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 05/21] target/i386: " Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 06/21] target/xtensa: Include "qemu/timer.h" to use NANOSECONDS_PER_SECOND Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 07/21] target/ppc: Include "exec/exec-all.h" which provides tlb_flush() Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 08/21] target/hppa: Include "qemu/log.h" to use qemu_log() Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary Philippe Mathieu-Daudé
2018-05-29 11:40 ` Cornelia Huck
2018-05-30 3:12 ` Philippe Mathieu-Daudé
2018-05-30 4:42 ` Michael S. Tsirkin
2018-05-30 5:50 ` Philippe Mathieu-Daudé
2018-05-30 6:19 ` Philippe Mathieu-Daudé
2018-05-30 12:55 ` Michael S. Tsirkin
2018-05-30 9:32 ` Paolo Bonzini
2018-05-30 10:12 ` Cornelia Huck
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 10/21] hw: Do not include "exec/ioport.h" " Philippe Mathieu-Daudé
2018-05-29 7:59 ` Marcel Apfelbaum
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 11/21] hw: Do not include "exec/address-spaces.h" " Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 12/21] hw: Do not include "sysemu/block-backend.h" " Philippe Mathieu-Daudé
2018-05-29 10:14 ` Cornelia Huck
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 13/21] hw: Do not include "sysemu/blockdev.h" " Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 14/21] " Philippe Mathieu-Daudé
2018-05-29 11:03 ` Cornelia Huck
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 15/21] hw/block/nvme: Include "qemu/cutils.h" directly in the source file Philippe Mathieu-Daudé
2018-05-29 0:42 ` Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 16/21] hw/misc/mips_itu: Cleanup includes Philippe Mathieu-Daudé
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 17/21] hw/misc/sga: Use the correct ISA include Philippe Mathieu-Daudé
2018-05-29 7:58 ` Marcel Apfelbaum [this message]
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 18/21] hw/hppa: Remove unused include Philippe Mathieu-Daudé
2018-05-29 11:27 ` Thomas Huth
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 19/21] hw/i386/pc: " Philippe Mathieu-Daudé
2018-05-29 7:58 ` Marcel Apfelbaum
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 20/21] hw/ide: " Philippe Mathieu-Daudé
2018-05-29 11:35 ` Thomas Huth
2018-05-30 20:29 ` John Snow
2018-05-28 23:27 ` [Qemu-devel] [PATCH v4 21/21] hw: Clean "hw/devices.h" includes Philippe Mathieu-Daudé
2018-05-29 0:07 ` [Qemu-devel] [PATCH v4 00/21] Includes cleanup Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145a7511-f2f9-6535-9711-8614a2ec16f1@gmail.com \
--to=marcel.apfelbaum@gmail.com \
--cc=f4bug@amsat.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).