From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ao4Ep-00026G-OY for qemu-devel@nongnu.org; Thu, 07 Apr 2016 03:20:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ao4Em-0004cF-Jt for qemu-devel@nongnu.org; Thu, 07 Apr 2016 03:20:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ao4Em-0004c3-EV for qemu-devel@nongnu.org; Thu, 07 Apr 2016 03:20:20 -0400 From: P J P Date: Thu, 7 Apr 2016 12:50:08 +0530 Message-Id: <1460013608-16670-1-git-send-email-ppandit@redhat.com> Subject: [Qemu-devel] [PATCH] i386: kvmvapic: initialise imm32 variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qemu Developers Cc: Paolo Bonzini , Prasad J Pandit , Donghai Zdh From: Prasad J Pandit When processing Task Priorty Register(TPR) access, it could leak automatic stack variable 'imm32' in patch_instruction(). Initialise the variable to avoid it. Reported by: Donghai Zdh Signed-off-by: Prasad J Pandit --- hw/i386/kvmvapic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index c69f374..ff1e31a 100644 --- a/hw/i386/kvmvapic.c +++ b/hw/i386/kvmvapic.c @@ -394,7 +394,7 @@ static void patch_instruction(VAPICROMState *s, X86CPU *cpu, target_ulong ip) CPUX86State *env = &cpu->env; VAPICHandlers *handlers; uint8_t opcode[2]; - uint32_t imm32; + uint32_t imm32 = 0; target_ulong current_pc = 0; target_ulong current_cs_base = 0; int current_flags = 0; -- 2.5.5