From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ao78E-0007di-JN for qemu-devel@nongnu.org; Thu, 07 Apr 2016 06:25:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ao78B-00078L-DN for qemu-devel@nongnu.org; Thu, 07 Apr 2016 06:25:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ao78B-00078H-7V for qemu-devel@nongnu.org; Thu, 07 Apr 2016 06:25:43 -0400 From: P J P Date: Thu, 7 Apr 2016 15:55:31 +0530 Message-Id: <1460024731-14533-1-git-send-email-ppandit@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] net: stellaris_enet: check packet length against receive buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qemu Developers Cc: Oleksandr Bazhaniuk , Jason Wang , Prasad J Pandit From: Prasad J Pandit When receiving packets over Stellaris ethernet controller, it uses receive buffer of size 2048 bytes. In case the controller accepts large(MTU) packets, it could lead to memory corruption. Add check to avoid it. Reported by: Oleksandr Bazhaniuk Signed-off-by: Prasad J Pandit --- hw/net/stellaris_enet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c index 21a4773..47b869a 100644 --- a/hw/net/stellaris_enet.c +++ b/hw/net/stellaris_enet.c @@ -237,6 +237,9 @@ static ssize_t stellaris_enet_receive(NetClientState *nc, const uint8_t *buf, si n -= 31; s->np++; + if (size >= sizeof(s->rx[n].data) - 6) { + return -1; + } s->rx[n].len = size + 6; p = s->rx[n].data; *(p++) = (size + 6); -- 2.5.5