From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoD9B-00041Z-J8 for qemu-devel@nongnu.org; Thu, 07 Apr 2016 12:51:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoD98-0001cm-6i for qemu-devel@nongnu.org; Thu, 07 Apr 2016 12:51:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoD98-0001ci-1K for qemu-devel@nongnu.org; Thu, 07 Apr 2016 12:51:06 -0400 From: Paolo Bonzini Date: Thu, 7 Apr 2016 18:50:41 +0200 Message-Id: <1460047845-14488-12-git-send-email-pbonzini@redhat.com> In-Reply-To: <1460047845-14488-1-git-send-email-pbonzini@redhat.com> References: <1460047845-14488-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 11/15] spapr: fix possible Negative array index read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gonglei From: Gonglei fix CID 1351391. Signed-off-by: Gonglei Message-Id: <1456998223-12356-6-git-send-email-arei.gonglei@huawei.com> Signed-off-by: Paolo Bonzini --- hw/ppc/spapr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index e7be21e..feaab08 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -2208,6 +2208,10 @@ static void spapr_machine_device_plug(HotplugHandler *hotplug_dev, if (*errp) { return; } + if (node < 0 || node >= MAX_NODES) { + error_setg(errp, "Invaild node %d", node); + return; + } /* * Currently PowerPC kernel doesn't allow hot-adding memory to -- 2.5.5