qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PULL 01/15] ps2kbd: default to scancode_set 2, as with KBD_CMD_RESET
Date: Thu,  7 Apr 2016 18:50:31 +0200	[thread overview]
Message-ID: <1460047845-14488-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1460047845-14488-1-git-send-email-pbonzini@redhat.com>

From: Hervé Poussineau <hpoussin@reactos.org>

This line has been added in commit ef74679a810fe6858f625b9d52b68cc3fc61eb3d with
other initializations. However, scancode set 0 doesn't exist (only 1, 2, 3).
This works well as long as operating system is resetting keyboard, or overwriting
the current scancode set with the one it wants.

This fixes IBM 40p firmware, which doesn't bother sending KBD_CMD_RESET or KBD_CMD_SCANCODE.

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Message-Id: <1458714100-28885-1-git-send-email-hpoussin@reactos.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/input/ps2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index 58892d5..a8aa36f 100644
--- a/hw/input/ps2.c
+++ b/hw/input/ps2.c
@@ -628,7 +628,7 @@ static void ps2_kbd_reset(void *opaque)
     ps2_common_reset(&s->common);
     s->scan_enabled = 0;
     s->translate = 0;
-    s->scancode_set = 0;
+    s->scancode_set = 2;
 }
 
 static void ps2_mouse_reset(void *opaque)
-- 
2.5.5

  reply	other threads:[~2016-04-07 16:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 16:50 [Qemu-devel] [PULL 00/15] Misc patches for QEMU 2.6.0-rc2 Paolo Bonzini
2016-04-07 16:50 ` Paolo Bonzini [this message]
2016-04-07 18:04   ` [Qemu-devel] [PULL 01/15] ps2kbd: default to scancode_set 2, as with KBD_CMD_RESET Peter Maydell
2016-04-07 16:50 ` [Qemu-devel] [PULL 02/15] hw/timer: Revert "hpet: inverse polarity when pin above ISA_NUM_IRQS" Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 03/15] docs: fix typo in memory.txt Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 04/15] nbd: Return correct error for write to read-only export Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 05/15] nbd: Avoid bitrot in TRACE() usage Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 06/15] nbd: Improve debug traces on little-endian Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 07/15] qemu-nbd: Document -x option Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 08/15] nbd: Fix NBD unsupported options Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 09/15] nbd: Don't kill server when client requests unknown option Paolo Bonzini
2016-04-07 22:14   ` Eric Blake
2016-04-07 16:50 ` [Qemu-devel] [PULL 10/15] nbd: do not hang nbd_wr_syncv if outside a coroutine and no available data Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 11/15] spapr: fix possible Negative array index read Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 12/15] hostmem-file: fix memory leak Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 13/15] translate-all: add missing fold of tb_ctx into tcg_ctx Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 14/15] tests: ignore test-logging Paolo Bonzini
2016-04-07 16:50 ` [Qemu-devel] [PULL 15/15] target-i386: check for PKU even for non-writable pages Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460047845-14488-2-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).