From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoUVZ-0000C8-2I for qemu-devel@nongnu.org; Fri, 08 Apr 2016 07:23:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoUVV-0004nR-0S for qemu-devel@nongnu.org; Fri, 08 Apr 2016 07:23:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoUVU-0004nM-Qm for qemu-devel@nongnu.org; Fri, 08 Apr 2016 07:23:20 -0400 From: Igor Mammedov Date: Fri, 8 Apr 2016 13:23:13 +0200 Message-Id: <1460114594-236342-2-git-send-email-imammedo@redhat.com> In-Reply-To: <1460114594-236342-1-git-send-email-imammedo@redhat.com> References: <1460114594-236342-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH for-2.6 v2 1/2] pc: acpi: tpm: add missing MMIO resource to PCI0._CRS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com, stefanb@us.ibm.com, crobinso@redhat.com Windows will fail initialize TMP driver with the reason: 'device cannot find enough free resources' That happens because parent BUS doesn't describe MMIO resources used by TPM child device. Fix it by describing it in top-most parent bus scope PCI0. It was 'regressed' by commit 5cb18b3d TPM2 ACPI table support with following fixup 9e472263 acpi: add missing ssdt which did the right thing by moving TPM to BUS it belongs to but lacked a proper resource declaration. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 35180ef..784870e 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -2167,6 +2167,11 @@ build_dsdt(GArray *table_data, GArray *linker, 0, pci->w64.begin, pci->w64.end - 1, 0, pci->w64.end - pci->w64.begin)); } + + if (misc->tpm_version != TPM_VERSION_UNSPEC) { + aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE, + TPM_TIS_ADDR_SIZE, AML_READ_WRITE)); + } aml_append(scope, aml_name_decl("_CRS", crs)); /* reserve GPE0 block resources */ -- 1.8.3.1