From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Ladi Prosek <lprosek@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PULL 5/5] virtio-input: fix emulated tablet axis ranges
Date: Mon, 11 Apr 2016 12:29:43 +0200 [thread overview]
Message-ID: <1460370583-29038-6-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1460370583-29038-1-git-send-email-kraxel@redhat.com>
From: Ladi Prosek <lprosek@redhat.com>
The reported maximum was wrong. The X and Y coordinates are 0-based
so if size is 8000 maximum must be 7FFF.
Signed-off-by: Ladi Prosek <lprosek@redhat.com>
Message-id: 1460128893-10244-1-git-send-email-lprosek@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/input/virtio-input-hid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c
index fe6d37f..3ee0c18 100644
--- a/hw/input/virtio-input-hid.c
+++ b/hw/input/virtio-input-hid.c
@@ -484,12 +484,12 @@ static struct virtio_input_config virtio_tablet_config[] = {
.select = VIRTIO_INPUT_CFG_ABS_INFO,
.subsel = ABS_X,
.size = sizeof(virtio_input_absinfo),
- .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE),
+ .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1),
},{
.select = VIRTIO_INPUT_CFG_ABS_INFO,
.subsel = ABS_Y,
.size = sizeof(virtio_input_absinfo),
- .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE),
+ .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1),
},
{ /* end of list */ },
};
--
1.8.3.1
next prev parent reply other threads:[~2016-04-11 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 10:29 [Qemu-devel] [PULL 0/5] virtio-input; live migration support, various bugfixes Gerd Hoffmann
2016-04-11 10:29 ` [Qemu-devel] [PULL 1/5] virtio-input: add missing key mappings Gerd Hoffmann
2016-04-11 10:29 ` [Qemu-devel] [PULL 2/5] virtio-input: retrieve EV_LED host config bits Gerd Hoffmann
2016-04-11 10:29 ` [Qemu-devel] [PULL 3/5] virtio-input: implement pass-through evdev writes Gerd Hoffmann
2016-04-11 10:29 ` [Qemu-devel] [PULL 4/5] virtio-input: add live migration support Gerd Hoffmann
2016-04-11 10:29 ` Gerd Hoffmann [this message]
2016-04-11 12:30 ` [Qemu-devel] [PULL 0/5] virtio-input; live migration support, various bugfixes Peter Maydell
2016-04-11 15:12 ` Gerd Hoffmann
2016-04-11 15:17 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460370583-29038-6-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=lprosek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).