From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apcFU-0004vY-TE for qemu-devel@nongnu.org; Mon, 11 Apr 2016 09:51:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apcFP-0003mR-Ag for qemu-devel@nongnu.org; Mon, 11 Apr 2016 09:51:28 -0400 Received: from smtp.citrix.com ([66.165.176.89]:37825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apcFP-0003mE-6p for qemu-devel@nongnu.org; Mon, 11 Apr 2016 09:51:23 -0400 From: Anthony PERARD Date: Mon, 11 Apr 2016 14:51:06 +0100 Message-ID: <1460382666-29885-1-git-send-email-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH for-2.6] xen: Fix IDE unplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefano Stabellini , John Snow , Max Reitz , Kevin Wolf , Anthony PERARD After commit e5e7855 (blockdev: Separate BB name management), starting a guest with PVHVM support result in this assert: qemu-system-i386: block/block-backend.c:173: blk_delete: Assertion `!blk->name' failed. A backtrace show that a caller is pci_piix3_xen_ide_unplug(). This patch fix it. Signed-off-by: Anthony PERARD --- hw/ide/piix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index 0a4cbcb..6d76ce9 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -189,6 +189,7 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev) idedev = pci_ide->bus[di->bus].slave; } idedev->conf.blk = NULL; + monitor_remove_blk(blk); blk_unref(blk); } } -- Anthony PERARD