* [Qemu-devel] [PATCH for-2.6] xen: Fix IDE unplug
@ 2016-04-11 13:51 Anthony PERARD
2016-04-11 18:22 ` Stefano Stabellini
0 siblings, 1 reply; 3+ messages in thread
From: Anthony PERARD @ 2016-04-11 13:51 UTC (permalink / raw)
To: qemu-devel
Cc: Stefano Stabellini, John Snow, Max Reitz, Kevin Wolf,
Anthony PERARD
After commit e5e7855 (blockdev: Separate BB name management), starting a
guest with PVHVM support result in this assert:
qemu-system-i386: block/block-backend.c:173: blk_delete: Assertion `!blk->name' failed.
A backtrace show that a caller is pci_piix3_xen_ide_unplug().
This patch fix it.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
hw/ide/piix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ide/piix.c b/hw/ide/piix.c
index 0a4cbcb..6d76ce9 100644
--- a/hw/ide/piix.c
+++ b/hw/ide/piix.c
@@ -189,6 +189,7 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev)
idedev = pci_ide->bus[di->bus].slave;
}
idedev->conf.blk = NULL;
+ monitor_remove_blk(blk);
blk_unref(blk);
}
}
--
Anthony PERARD
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH for-2.6] xen: Fix IDE unplug
2016-04-11 13:51 [Qemu-devel] [PATCH for-2.6] xen: Fix IDE unplug Anthony PERARD
@ 2016-04-11 18:22 ` Stefano Stabellini
2016-04-11 20:31 ` John Snow
0 siblings, 1 reply; 3+ messages in thread
From: Stefano Stabellini @ 2016-04-11 18:22 UTC (permalink / raw)
To: Anthony PERARD
Cc: qemu-devel, Stefano Stabellini, John Snow, Max Reitz, Kevin Wolf
On Mon, 11 Apr 2016, Anthony PERARD wrote:
> After commit e5e7855 (blockdev: Separate BB name management), starting a
> guest with PVHVM support result in this assert:
> qemu-system-i386: block/block-backend.c:173: blk_delete: Assertion `!blk->name' failed.
>
> A backtrace show that a caller is pci_piix3_xen_ide_unplug().
>
> This patch fix it.
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> hw/ide/piix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ide/piix.c b/hw/ide/piix.c
> index 0a4cbcb..6d76ce9 100644
> --- a/hw/ide/piix.c
> +++ b/hw/ide/piix.c
> @@ -189,6 +189,7 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev)
> idedev = pci_ide->bus[di->bus].slave;
> }
> idedev->conf.blk = NULL;
> + monitor_remove_blk(blk);
> blk_unref(blk);
> }
> }
> --
> Anthony PERARD
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.6] xen: Fix IDE unplug
2016-04-11 18:22 ` Stefano Stabellini
@ 2016-04-11 20:31 ` John Snow
0 siblings, 0 replies; 3+ messages in thread
From: John Snow @ 2016-04-11 20:31 UTC (permalink / raw)
To: Stefano Stabellini, Anthony PERARD; +Cc: Kevin Wolf, qemu-devel, Max Reitz
On 04/11/2016 02:22 PM, Stefano Stabellini wrote:
> On Mon, 11 Apr 2016, Anthony PERARD wrote:
>> After commit e5e7855 (blockdev: Separate BB name management), starting a
>> guest with PVHVM support result in this assert:
>> qemu-system-i386: block/block-backend.c:173: blk_delete: Assertion `!blk->name' failed.
>>
>> A backtrace show that a caller is pci_piix3_xen_ide_unplug().
>>
>> This patch fix it.
>>
>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>
>> hw/ide/piix.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/ide/piix.c b/hw/ide/piix.c
>> index 0a4cbcb..6d76ce9 100644
>> --- a/hw/ide/piix.c
>> +++ b/hw/ide/piix.c
>> @@ -189,6 +189,7 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev)
>> idedev = pci_ide->bus[di->bus].slave;
>> }
>> idedev->conf.blk = NULL;
>> + monitor_remove_blk(blk);
>> blk_unref(blk);
>> }
>> }
>> --
>> Anthony PERARD
>>
>
Thanks, applied to my IDE tree:
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-11 20:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-11 13:51 [Qemu-devel] [PATCH for-2.6] xen: Fix IDE unplug Anthony PERARD
2016-04-11 18:22 ` Stefano Stabellini
2016-04-11 20:31 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).