From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34658)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1apdVt-0005mq-2l
	for qemu-devel@nongnu.org; Mon, 11 Apr 2016 11:12:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1apdVo-0007KC-3t
	for qemu-devel@nongnu.org; Mon, 11 Apr 2016 11:12:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50037)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1apdVn-0007K2-Ux
	for qemu-devel@nongnu.org; Mon, 11 Apr 2016 11:12:24 -0400
Message-ID: <1460387541.1765.12.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 11 Apr 2016 17:12:21 +0200
In-Reply-To: <CAFEAcA9kgdVbePr0Vf2N+Z_qv7hiSgK9AzfyVVev49MFJ5Zu_g@mail.gmail.com>
References: <1460370583-29038-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA9kgdVbePr0Vf2N+Z_qv7hiSgK9AzfyVVev49MFJ5Zu_g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PULL 0/5] virtio-input;
 live migration support, various bugfixes.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

> Hi. I'm afraid this doesn't compile on ppc64be:
>=20
> /home/pm215/qemu/hw/input/virtio-input-hid.c:487:9: error: suggest
> parentheses around =E2=80=98-=E2=80=99 in operand of =E2=80=98&=E2=80=99 =
[-Werror=3Dparentheses]
>          .u.abs.max =3D const_le32(INPUT_EVENT_ABS_SIZE - 1),
>          ^
> /home/pm215/qemu/hw/input/virtio-input-hid.c:492:9: error: suggest
> parentheses around =E2=80=98-=E2=80=99 in operand of =E2=80=98&=E2=80=99 =
[-Werror=3Dparentheses]
>          .u.abs.max =3D const_le32(INPUT_EVENT_ABS_SIZE - 1),
>          ^
>=20
> It looks like the const_le32() and const_le16() macros in
> include/hw/virtio/virtio-input.h are missing brackets around the macro
> argument

Indeed.  /me needs a be machine.

>  -- can you send a patch which adds the missing brackets, please?

Sure.

> (Side question, why is an apparently generic endianness support
> macro implemented in virtio-input.h ?)

Suggestions for a better place?  Looks like there isn't something like
byteorder.h ...

cheers,
  Gerd