* [Qemu-devel] [PATCH] virtio-input: add parenthesis to const_le32
@ 2016-04-11 15:19 Gerd Hoffmann
2016-04-11 16:14 ` Eric Blake
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2016-04-11 15:19 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Michael S. Tsirkin
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
include/hw/virtio/virtio-input.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/hw/virtio/virtio-input.h b/include/hw/virtio/virtio-input.h
index af1c207..6d81c7c 100644
--- a/include/hw/virtio/virtio-input.h
+++ b/include/hw/virtio/virtio-input.h
@@ -15,10 +15,10 @@ typedef struct virtio_input_event virtio_input_event;
#if defined(HOST_WORDS_BIGENDIAN)
# define const_le32(_x) \
- (((_x & 0x000000ffU) << 24) | \
- ((_x & 0x0000ff00U) << 8) | \
- ((_x & 0x00ff0000U) >> 8) | \
- ((_x & 0xff000000U) >> 24))
+ ((((_x) & 0x000000ffU) << 24) | \
+ (((_x) & 0x0000ff00U) << 8) | \
+ (((_x) & 0x00ff0000U) >> 8) | \
+ (((_x) & 0xff000000U) >> 24))
# define const_le16(_x) \
(((_x & 0x00ff) << 8) | \
((_x & 0xff00) >> 8))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-input: add parenthesis to const_le32
2016-04-11 15:19 [Qemu-devel] [PATCH] virtio-input: add parenthesis to const_le32 Gerd Hoffmann
@ 2016-04-11 16:14 ` Eric Blake
0 siblings, 0 replies; 2+ messages in thread
From: Eric Blake @ 2016-04-11 16:14 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: Michael S. Tsirkin
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On 04/11/2016 09:19 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> include/hw/virtio/virtio-input.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
An explanation would have been helpful.
> #if defined(HOST_WORDS_BIGENDIAN)
> # define const_le32(_x) \
> - (((_x & 0x000000ffU) << 24) | \
The problem you are fixing is that _x needs parenthesis.
> + ((((_x) & 0x000000ffU) << 24) | \
and you indeed added it, but I had to hunt because there was no
explanation in the commit message.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-11 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-11 15:19 [Qemu-devel] [PATCH] virtio-input: add parenthesis to const_le32 Gerd Hoffmann
2016-04-11 16:14 ` Eric Blake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).