From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqKw0-0004YO-6e for qemu-devel@nongnu.org; Wed, 13 Apr 2016 09:34:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqKvx-0006Bw-1T for qemu-devel@nongnu.org; Wed, 13 Apr 2016 09:34:20 -0400 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:36715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqKvw-0006BG-KC for qemu-devel@nongnu.org; Wed, 13 Apr 2016 09:34:16 -0400 Received: by mail-wm0-x22b.google.com with SMTP id v188so175077860wme.1 for ; Wed, 13 Apr 2016 06:34:16 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= Date: Wed, 13 Apr 2016 14:34:17 +0100 Message-Id: <1460554457-18119-1-git-send-email-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [RFC] libqtest: dump child invocation when QTEST_LOG set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= The QTEST_LOG environment is used for debugging qtest interactions with a child process. When it is defined we now also dump the invocation line to stderr to make it easier for people to see how QEMU was invoked. Signed-off-by: Alex Bennée --- tests/libqtest.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index b12a9e4..dd94abf 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -171,6 +171,7 @@ QTestState *qtest_init(const char *extra_args) s->qemu_pid = fork(); if (s->qemu_pid == 0) { + bool qtest_log = getenv("QTEST_LOG"); setenv("QEMU_AUDIO_DRV", "none", true); command = g_strdup_printf("exec %s " "-qtest unix:%s,nowait " @@ -179,9 +180,12 @@ QTestState *qtest_init(const char *extra_args) "-machine accel=qtest " "-display none " "%s", qemu_binary, socket_path, - getenv("QTEST_LOG") ? "/dev/fd/2" : "/dev/null", + qtest_log ? "/dev/fd/2" : "/dev/null", qmp_socket_path, extra_args ?: ""); + if (qtest_log) { + fprintf(stderr, "%s\n", command); + } execlp("/bin/sh", "sh", "-c", command, NULL); exit(1); } -- 2.7.4