Re: [Qemu-devel] [PATCH] accel: make configure_accelerator return void

["Wei, Jiangang" <weijg.fnst@cn.fujitsu.com>]

ping...
Any comments?
On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote:
> Return the negated value of accel_initialised is meaningless,
> and the caller vl doesn't check it.
> 
> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> ---
>  accel.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/accel.c b/accel.c
> index 0510b90..403eb5e 100644
> --- a/accel.c
> +++ b/accel.c
> @@ -77,7 +77,7 @@ static int accel_init_machine(AccelClass *acc, MachineState *ms)
>      return ret;
>  }
>  
> -int configure_accelerator(MachineState *ms)
> +void configure_accelerator(MachineState *ms)
>  {
>      const char *p;
>      char buf[10];
> @@ -128,8 +128,6 @@ int configure_accelerator(MachineState *ms)
>      if (init_failed) {
>          fprintf(stderr, "Back to %s accelerator.\n", acc->name);
>      }
> -
> -    return !accel_initialised;
>  }
>  
>