From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqYQz-00012R-UR for qemu-devel@nongnu.org; Wed, 13 Apr 2016 23:59:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqYQv-0001mi-AV for qemu-devel@nongnu.org; Wed, 13 Apr 2016 23:59:13 -0400 From: Wei Jiangang Date: Thu, 14 Apr 2016 11:58:02 +0800 Message-ID: <1460606282-4570-1-git-send-email-weijg.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v2] accel: make configure_accelerator return void List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, xiecl.fnst@cn.fujitsu.com, Wei Jiangang Return the negated value of accel_initialised is meaningless, and the caller vl doesn't check it. Signed-off-by: Wei Jiangang --- accel.c | 4 +--- include/sysemu/accel.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/accel.c b/accel.c index 0510b90..403eb5e 100644 --- a/accel.c +++ b/accel.c @@ -77,7 +77,7 @@ static int accel_init_machine(AccelClass *acc, MachineState *ms) return ret; } -int configure_accelerator(MachineState *ms) +void configure_accelerator(MachineState *ms) { const char *p; char buf[10]; @@ -128,8 +128,6 @@ int configure_accelerator(MachineState *ms) if (init_failed) { fprintf(stderr, "Back to %s accelerator.\n", acc->name); } - - return !accel_initialised; } diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h index 997720f..c230f1b 100644 --- a/include/sysemu/accel.h +++ b/include/sysemu/accel.h @@ -57,6 +57,6 @@ typedef struct AccelClass { extern int tcg_tb_size; -int configure_accelerator(MachineState *ms); +void configure_accelerator(MachineState *ms); #endif -- 1.9.3