qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>,
	Dinar Valeev <dvaleev@suse.de>, Dirk Mueller <dmueller@suse.com>
Subject: Re: [Qemu-devel] [PATCH] hid: Extend the event queue size to 1024
Date: Thu, 14 Apr 2016 17:17:47 +0200	[thread overview]
Message-ID: <1460647067.18572.31.camel@redhat.com> (raw)
In-Reply-To: <1460643912-244245-1-git-send-email-agraf@suse.de>

On Do, 2016-04-14 at 16:25 +0200, Alexander Graf wrote:
> We can currently buffer up to 16 events in our event queue for input
> devices. While it sounds like 16 events backlog for everyone should
> be enough, our automated testing tools (OpenQA) manage to easily
> type faster than our guests can handle.

IMO you should fix OpenQA to type slower then.

Real hardware is made for human typing speeds.  qemu emulates real
hardware.  Typing insane fast is going to cause problems because the
hardware interfaces are not designed for that.

Note the ps/2 keyboard has only a 16 byte queue too.  Used to be 256
bytes, but that caused problems because this diverges from real hardware
(see commit 2858ab09e6f708e381fc1a1cc87e747a690c4884 for all the
details).

Note that the generic input code has support for slow typing already
(see qemu_input_event_send_key_delay in ui/input.c).  That queue will
(a) work for all keyboard devices and (b) isn't visible to the guest, so
using that might be a reasonable option if you can't put the delay logic
into OpenQA.  How to you feed the guest with keystrokes?  monitor?  vnc?

cheers,
  Gerd

  reply	other threads:[~2016-04-14 15:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14 14:25 [Qemu-devel] [PATCH] hid: Extend the event queue size to 1024 Alexander Graf
2016-04-14 15:17 ` Gerd Hoffmann [this message]
2016-04-14 15:29   ` Alexander Graf
2016-04-14 16:19     ` Gerd Hoffmann
2016-04-15 12:18       ` Dinar Valeev
2016-04-18  6:53     ` Gerd Hoffmann
2016-04-18  7:26       ` Alexander Graf
2016-04-18  9:21         ` Gerd Hoffmann
2016-04-18  9:27           ` Alexander Graf
2016-04-19  9:28 ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460647067.18572.31.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=agraf@suse.de \
    --cc=dmueller@suse.com \
    --cc=dvaleev@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).