From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH] block: Inactivate all nodes at migration source
Date: Fri, 15 Apr 2016 11:11:06 +0800 [thread overview]
Message-ID: <1460689866-31020-1-git-send-email-famz@redhat.com> (raw)
qcow2 is not necessarily the top layer node. Since bdrv_inactivate()
doesn't recurse, we should ensure all block nodes are inactivated.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index d4939b4..1c575e4 100644
--- a/block.c
+++ b/block.c
@@ -3270,7 +3270,7 @@ int bdrv_inactivate_all(void)
BlockDriverState *bs = NULL;
int ret;
- while ((bs = bdrv_next(bs)) != NULL) {
+ while ((bs = bdrv_next_node(bs)) != NULL) {
AioContext *aio_context = bdrv_get_aio_context(bs);
aio_context_acquire(aio_context);
--
2.8.0
next reply other threads:[~2016-04-15 3:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 3:11 Fam Zheng [this message]
2016-04-15 15:11 ` [Qemu-devel] [PATCH] block: Inactivate all nodes at migration source Kevin Wolf
2016-04-18 1:36 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460689866-31020-1-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).