From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqxTg-0005j4-UD for qemu-devel@nongnu.org; Fri, 15 Apr 2016 02:43:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqxTc-00072U-Tv for qemu-devel@nongnu.org; Fri, 15 Apr 2016 02:43:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqxTc-00072P-P9 for qemu-devel@nongnu.org; Fri, 15 Apr 2016 02:43:36 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2FA533B71F for ; Fri, 15 Apr 2016 06:43:36 +0000 (UTC) From: Gerd Hoffmann Date: Fri, 15 Apr 2016 08:43:29 +0200 Message-Id: <1460702609-25971-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH] Revert "acpi: mark PMTIMER as unlocked" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Gerd Hoffmann , "Michael S. Tsirkin" , Igor Mammedov This reverts commit 7070e085d490c396f9237c8f10bf8b6e69cd0066. Commit message claims locking is not needed, but that appears to not be true, seabios ehci driver runs into timekeeping problems with this, see https://bugzilla.redhat.com/show_bug.cgi?id=1322713 Signed-off-by: Gerd Hoffmann --- hw/acpi/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index 7925a1a..6a2f452 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -536,7 +536,6 @@ void acpi_pm_tmr_init(ACPIREGS *ar, acpi_update_sci_fn update_sci, ar->tmr.timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, acpi_pm_tmr_timer, ar); memory_region_init_io(&ar->tmr.io, memory_region_owner(parent), &acpi_pm_tmr_ops, ar, "acpi-tmr", 4); - memory_region_clear_global_locking(&ar->tmr.io); memory_region_add_subregion(parent, 8, &ar->tmr.io); } -- 1.8.3.1