From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1as343-0006DE-2C for qemu-devel@nongnu.org; Mon, 18 Apr 2016 02:53:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1as33y-0005Zb-UH for qemu-devel@nongnu.org; Mon, 18 Apr 2016 02:53:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1as33y-0005ZM-Jn for qemu-devel@nongnu.org; Mon, 18 Apr 2016 02:53:38 -0400 Message-ID: <1460962415.21910.3.camel@redhat.com> From: Gerd Hoffmann Date: Mon, 18 Apr 2016 08:53:35 +0200 In-Reply-To: <570FB743.6060808@suse.de> References: <1460643912-244245-1-git-send-email-agraf@suse.de> <1460647067.18572.31.camel@redhat.com> <570FB743.6060808@suse.de> Content-Type: multipart/mixed; boundary="=-UBLoWPTu9JK7frdUCYpg" Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] hid: Extend the event queue size to 1024 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, Juan Quintela , Dinar Valeev , Dirk Mueller --=-UBLoWPTu9JK7frdUCYpg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, > Vnc already uses qemu_input_event_send_key_delay today, so I'm not sure= =20 > where things fall apart. Well, not everywhere. Try the attached patch. Also worth trying: * use xhci instead of ohci (current slof should handle kbd-via-xhci fine) * use virtio-keyboard (no slof driver yet as far I know, also needs a recent linux kernel). cheers, Gerd --=-UBLoWPTu9JK7frdUCYpg Content-Disposition: attachment; filename="0001-vnc-add-configurable-keyboard-delay.patch" Content-Type: text/x-patch; name="0001-vnc-add-configurable-keyboard-delay.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA4NzBkYWYxODY1NDMwYjUxMDdjZmFkMjUxNDJkMzBkMDA2YTBlYzJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KRGF0 ZTogTW9uLCAxOCBBcHIgMjAxNiAwODo0OTowMCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIHZuYzog YWRkIGNvbmZpZ3VyYWJsZSBrZXlib2FyZCBkZWxheQoKLS0tCiB1aS92bmMuYyB8IDEzICsrKysr KysrKysrLS0KIHVpL3ZuYy5oIHwgIDEgKwogMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3VpL3ZuYy5jIGIvdWkvdm5jLmMKaW5k ZXggZDJlYmYxZi4uZWEzYjNkNCAxMDA2NDQKLS0tIGEvdWkvdm5jLmMKKysrIGIvdWkvdm5jLmMK QEAgLTE2MjksNiArMTYyOSw3IEBAIHN0YXRpYyB2b2lkIHJlc2V0X2tleXMoVm5jU3RhdGUgKnZz KQogICAgIGZvcihpID0gMDsgaSA8IDI1NjsgaSsrKSB7CiAgICAgICAgIGlmICh2cy0+bW9kaWZp ZXJzX3N0YXRlW2ldKSB7CiAgICAgICAgICAgICBxZW11X2lucHV0X2V2ZW50X3NlbmRfa2V5X251 bWJlcih2cy0+dmQtPmRjbC5jb24sIGksIGZhbHNlKTsKKyAgICAgICAgICAgIHFlbXVfaW5wdXRf ZXZlbnRfc2VuZF9rZXlfZGVsYXkodnMtPnZkLT5rZXlfZGVsYXlfbXMpOwogICAgICAgICAgICAg dnMtPm1vZGlmaWVyc19zdGF0ZVtpXSA9IDA7CiAgICAgICAgIH0KICAgICB9CkBAIC0xNjM4LDkg KzE2MzksOSBAQCBzdGF0aWMgdm9pZCBwcmVzc19rZXkoVm5jU3RhdGUgKnZzLCBpbnQga2V5c3lt KQogewogICAgIGludCBrZXljb2RlID0ga2V5c3ltMnNjYW5jb2RlKHZzLT52ZC0+a2JkX2xheW91 dCwga2V5c3ltKSAmIFNDQU5DT0RFX0tFWU1BU0s7CiAgICAgcWVtdV9pbnB1dF9ldmVudF9zZW5k X2tleV9udW1iZXIodnMtPnZkLT5kY2wuY29uLCBrZXljb2RlLCB0cnVlKTsKLSAgICBxZW11X2lu cHV0X2V2ZW50X3NlbmRfa2V5X2RlbGF5KDApOworICAgIHFlbXVfaW5wdXRfZXZlbnRfc2VuZF9r ZXlfZGVsYXkodnMtPnZkLT5rZXlfZGVsYXlfbXMpOwogICAgIHFlbXVfaW5wdXRfZXZlbnRfc2Vu ZF9rZXlfbnVtYmVyKHZzLT52ZC0+ZGNsLmNvbiwga2V5Y29kZSwgZmFsc2UpOwotICAgIHFlbXVf aW5wdXRfZXZlbnRfc2VuZF9rZXlfZGVsYXkoMCk7CisgICAgcWVtdV9pbnB1dF9ldmVudF9zZW5k X2tleV9kZWxheSh2cy0+dmQtPmtleV9kZWxheV9tcyk7CiB9CiAKIHN0YXRpYyBpbnQgY3VycmVu dF9sZWRfc3RhdGUoVm5jU3RhdGUgKnZzKQpAQCAtMTc5Miw2ICsxNzkzLDcgQEAgc3RhdGljIHZv aWQgZG9fa2V5X2V2ZW50KFZuY1N0YXRlICp2cywgaW50IGRvd24sIGludCBrZXljb2RlLCBpbnQg c3ltKQogCiAgICAgaWYgKHFlbXVfY29uc29sZV9pc19ncmFwaGljKE5VTEwpKSB7CiAgICAgICAg IHFlbXVfaW5wdXRfZXZlbnRfc2VuZF9rZXlfbnVtYmVyKHZzLT52ZC0+ZGNsLmNvbiwga2V5Y29k ZSwgZG93bik7CisgICAgICAgIHFlbXVfaW5wdXRfZXZlbnRfc2VuZF9rZXlfZGVsYXkodnMtPnZk LT5rZXlfZGVsYXlfbXMpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIGJvb2wgbnVtbG9jayA9IHZz LT5tb2RpZmllcnNfc3RhdGVbMHg0NV07CiAgICAgICAgIGJvb2wgY29udHJvbCA9ICh2cy0+bW9k aWZpZXJzX3N0YXRlWzB4MWRdIHx8CkBAIC0xOTEzLDYgKzE5MTUsNyBAQCBzdGF0aWMgdm9pZCB2 bmNfcmVsZWFzZV9tb2RpZmllcnMoVm5jU3RhdGUgKnZzKQogICAgICAgICAgICAgY29udGludWU7 CiAgICAgICAgIH0KICAgICAgICAgcWVtdV9pbnB1dF9ldmVudF9zZW5kX2tleV9udW1iZXIodnMt PnZkLT5kY2wuY29uLCBrZXljb2RlLCBmYWxzZSk7CisgICAgICAgIHFlbXVfaW5wdXRfZXZlbnRf c2VuZF9rZXlfZGVsYXkodnMtPnZkLT5rZXlfZGVsYXlfbXMpOwogICAgIH0KIH0KIApAQCAtMzI0 OSw2ICszMjUyLDkgQEAgc3RhdGljIFFlbXVPcHRzTGlzdCBxZW11X3ZuY19vcHRzID0gewogICAg ICAgICAgICAgLm5hbWUgPSAibG9jay1rZXktc3luYyIsCiAgICAgICAgICAgICAudHlwZSA9IFFF TVVfT1BUX0JPT0wsCiAgICAgICAgIH0seworICAgICAgICAgICAgLm5hbWUgPSAia2V5LWRlbGF5 LW1zIiwKKyAgICAgICAgICAgIC50eXBlID0gUUVNVV9PUFRfTlVNQkVSLAorICAgICAgICB9LHsK ICAgICAgICAgICAgIC5uYW1lID0gInNhc2wiLAogICAgICAgICAgICAgLnR5cGUgPSBRRU1VX09Q VF9CT09MLAogICAgICAgICB9LHsKQEAgLTM0ODYsNiArMzQ5Miw3IEBAIHZvaWQgdm5jX2Rpc3Bs YXlfb3Blbihjb25zdCBjaGFyICppZCwgRXJyb3IgKiplcnJwKQogI2VuZGlmCiAgICAgaW50IGFj bCA9IDA7CiAgICAgaW50IGxvY2tfa2V5X3N5bmMgPSAxOworICAgIGludCBrZXlfZGVsYXlfbXM7 CiAKICAgICBpZiAoIXZzKSB7CiAgICAgICAgIGVycm9yX3NldGcoZXJycCwgIlZOQyBkaXNwbGF5 IG5vdCBhY3RpdmUiKTsKQEAgLTM2MDQsNiArMzYxMSw3IEBAIHZvaWQgdm5jX2Rpc3BsYXlfb3Bl bihjb25zdCBjaGFyICppZCwgRXJyb3IgKiplcnJwKQogCiAgICAgcmV2ZXJzZSA9IHFlbXVfb3B0 X2dldF9ib29sKG9wdHMsICJyZXZlcnNlIiwgZmFsc2UpOwogICAgIGxvY2tfa2V5X3N5bmMgPSBx ZW11X29wdF9nZXRfYm9vbChvcHRzLCAibG9jay1rZXktc3luYyIsIHRydWUpOworICAgIGtleV9k ZWxheV9tcyA9IHFlbXVfb3B0X2dldF9udW1iZXIob3B0cywgImtleS1kZWxheS1tcyIsIDEpOwog ICAgIHNhc2wgPSBxZW11X29wdF9nZXRfYm9vbChvcHRzLCAic2FzbCIsIGZhbHNlKTsKICNpZm5k ZWYgQ09ORklHX1ZOQ19TQVNMCiAgICAgaWYgKHNhc2wpIHsKQEAgLTM3MzUsNiArMzc0Myw3IEBA IHZvaWQgdm5jX2Rpc3BsYXlfb3Blbihjb25zdCBjaGFyICppZCwgRXJyb3IgKiplcnJwKQogICAg IH0KICNlbmRpZgogICAgIHZzLT5sb2NrX2tleV9zeW5jID0gbG9ja19rZXlfc3luYzsKKyAgICB2 cy0+a2V5X2RlbGF5X21zID0ga2V5X2RlbGF5X21zOwogCiAgICAgZGV2aWNlX2lkID0gcWVtdV9v cHRfZ2V0KG9wdHMsICJkaXNwbGF5Iik7CiAgICAgaWYgKGRldmljZV9pZCkgewpkaWZmIC0tZ2l0 IGEvdWkvdm5jLmggYi91aS92bmMuaAppbmRleCA4MWEzMjYxLi42NTY4YmNhIDEwMDY0NAotLS0g YS91aS92bmMuaAorKysgYi91aS92bmMuaApAQCAtMTU1LDYgKzE1NSw3IEBAIHN0cnVjdCBWbmNE aXNwbGF5CiAgICAgRGlzcGxheUNoYW5nZUxpc3RlbmVyIGRjbDsKICAgICBrYmRfbGF5b3V0X3Qg KmtiZF9sYXlvdXQ7CiAgICAgaW50IGxvY2tfa2V5X3N5bmM7CisgICAgaW50IGtleV9kZWxheV9t czsKICAgICBRZW11TXV0ZXggbXV0ZXg7CiAKICAgICBRRU1VQ3Vyc29yICpjdXJzb3I7Ci0tIAox LjguMy4xCgo= --=-UBLoWPTu9JK7frdUCYpg--