From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>
Subject: [Qemu-devel] [PATCH for-2.7 v3 03/12] curses: curses_display_init() stub
Date: Tue, 19 Apr 2016 16:55:19 -0300 [thread overview]
Message-ID: <1461095728-22055-4-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1461095728-22055-1-git-send-email-ehabkost@redhat.com>
One less #ifdef in vl.c.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2:
* Move stub file to stubs/ui/
Changes v2 -> v3:
* Move stub to header file
---
include/ui/console.h | 9 +++++++++
vl.c | 2 --
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/include/ui/console.h b/include/ui/console.h
index 6640348..f5fa9cb 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -466,7 +466,16 @@ static inline char *vnc_display_local_addr(const char *id)
#endif
/* curses.c */
+#ifdef CONFIG_CURSES
void curses_display_init(DisplayState *ds, int full_screen);
+#else
+static inline void curses_display_init(DisplayState *ds, int full_screen)
+{
+ /* This must never be called if CONFIG_CURSES is disabled */
+ error_report("curses support is disabled");
+ abort();
+}
+#endif
/* input.c */
int index_from_key(const char *key, size_t key_length);
diff --git a/vl.c b/vl.c
index cdb06dc..6e2336e 100644
--- a/vl.c
+++ b/vl.c
@@ -4540,11 +4540,9 @@ int main(int argc, char **argv, char **envp)
case DT_NOGRAPHIC:
(void)ds; /* avoid warning if no display is configured */
break;
-#if defined(CONFIG_CURSES)
case DT_CURSES:
curses_display_init(ds, full_screen);
break;
-#endif
#if defined(CONFIG_SDL)
case DT_SDL:
sdl_display_init(ds, full_screen, no_frame);
--
2.1.0
next prev parent reply other threads:[~2016-04-19 19:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 19:55 [Qemu-devel] [PATCH for-2.7 v3 00/12] vl: graphics stubs + #ifdef cleanup + DT_NOGRAPHIC cleanup Eduardo Habkost
2016-04-19 19:55 ` [Qemu-devel] [PATCH for-2.7 v3 01/12] vl: Add DT_COCOA DisplayType value Eduardo Habkost
2016-04-19 19:55 ` [Qemu-devel] [PATCH for-2.7 v3 02/12] vnc: Initialization stubs Eduardo Habkost
2016-04-19 19:55 ` Eduardo Habkost [this message]
2016-04-19 19:55 ` [Qemu-devel] [PATCH for-2.7 v3 04/12] sdl: " Eduardo Habkost
2016-04-19 19:55 ` [Qemu-devel] [PATCH for-2.7 v3 05/12] cocoa: cocoa_display_init() stub Eduardo Habkost
2016-04-19 19:55 ` [Qemu-devel] [PATCH for-2.7 v3 06/12] gtk: Initialization stubs Eduardo Habkost
2016-04-19 19:55 ` [Qemu-devel] [PATCH for-2.7 v3 07/12] spice: Initialization stubs on qemu-spice.h Eduardo Habkost
2016-04-19 19:55 ` [Qemu-devel] [PATCH for-2.7 v3 08/12] milkymist: Move DT_NOGRAPHIC check outside milkymist_tmu2_create() Eduardo Habkost
2016-04-19 19:55 ` [Qemu-devel] [PATCH for-2.7 v3 09/12] vl: Replace DT_NOGRAPHIC with machine option Eduardo Habkost
2016-04-19 19:55 ` [Qemu-devel] [PATCH for-2.7 v3 10/12] vl: Make display_type a local variable Eduardo Habkost
2016-04-19 19:55 ` [Qemu-devel] [PATCH for-2.7 v3 11/12] vl: Move DisplayType typedef to vl.c Eduardo Habkost
2016-04-19 19:55 ` [Qemu-devel] [PATCH for-2.7 v3 12/12] vl: Make display_remote a local variable Eduardo Habkost
2016-05-10 13:55 ` [Qemu-devel] [PATCH for-2.7 v3 00/12] vl: graphics stubs + #ifdef cleanup + DT_NOGRAPHIC cleanup Paolo Bonzini
2016-05-10 15:17 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461095728-22055-4-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=marcel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).