* [Qemu-devel] [PULL for-2.6 0/1] tags/xen-2016-04-20
@ 2016-04-20 11:14 Stefano Stabellini
2016-04-20 11:15 ` [Qemu-devel] [PULL for-2.6 1/1] xenfb: use the correct condition to avoid excessive looping Stefano Stabellini
2016-04-20 15:43 ` [Qemu-devel] [PULL for-2.6 0/1] tags/xen-2016-04-20 Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Stefano Stabellini @ 2016-04-20 11:14 UTC (permalink / raw)
To: peter.maydell; +Cc: qemu-devel, xen-devel, sstabellini
The following changes since commit 42bb626f7ebc9197d2943b897a99e127315275ab:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2016-04-12 09:34:52 +0100)
are available in the git repository at:
git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-2016-04-20
for you to fetch changes up to 4df26e88ee2f23c01418630368e87b719ed06b75:
xenfb: use the correct condition to avoid excessive looping (2016-04-12 10:16:08 -0700)
----------------------------------------------------------------
Xen 2016/04/20
----------------------------------------------------------------
Wei Liu (1):
xenfb: use the correct condition to avoid excessive looping
hw/display/xenfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 3+ messages in thread* [Qemu-devel] [PULL for-2.6 1/1] xenfb: use the correct condition to avoid excessive looping
2016-04-20 11:14 [Qemu-devel] [PULL for-2.6 0/1] tags/xen-2016-04-20 Stefano Stabellini
@ 2016-04-20 11:15 ` Stefano Stabellini
2016-04-20 15:43 ` [Qemu-devel] [PULL for-2.6 0/1] tags/xen-2016-04-20 Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2016-04-20 11:15 UTC (permalink / raw)
To: peter.maydell; +Cc: sstabellini, qemu-devel, xen-devel, Wei Liu
From: Wei Liu <wei.liu2@citrix.com>
In commit ac0487e1 ("xenfb.c: avoid expensive loops when prod <=
out_cons"), ">=" was used. In fact, a full ring is a legit state.
Correct the test to use ">".
Reported-by: "Hao, Xudong" <xudong.hao@intel.com>
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Tested-by: "Hao, Xudong" <xudong.hao@intel.com>
Acked-by: Anthony Perard <anthony.perard@citrix.com>
Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
---
hw/display/xenfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
index 40b096a..9866dfd 100644
--- a/hw/display/xenfb.c
+++ b/hw/display/xenfb.c
@@ -775,7 +775,7 @@ static void xenfb_handle_events(struct XenFB *xenfb)
prod = page->out_prod;
out_cons = page->out_cons;
- if (prod - out_cons >= XENFB_OUT_RING_LEN) {
+ if (prod - out_cons > XENFB_OUT_RING_LEN) {
return;
}
xen_rmb(); /* ensure we see ring contents up to prod */
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PULL for-2.6 0/1] tags/xen-2016-04-20
2016-04-20 11:14 [Qemu-devel] [PULL for-2.6 0/1] tags/xen-2016-04-20 Stefano Stabellini
2016-04-20 11:15 ` [Qemu-devel] [PULL for-2.6 1/1] xenfb: use the correct condition to avoid excessive looping Stefano Stabellini
@ 2016-04-20 15:43 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2016-04-20 15:43 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: QEMU Developers, xen-devel@lists.xensource.com Devel
On 20 April 2016 at 12:14, Stefano Stabellini <sstabellini@kernel.org> wrote:
> The following changes since commit 42bb626f7ebc9197d2943b897a99e127315275ab:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2016-04-12 09:34:52 +0100)
>
> are available in the git repository at:
>
>
> git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-2016-04-20
>
> for you to fetch changes up to 4df26e88ee2f23c01418630368e87b719ed06b75:
>
> xenfb: use the correct condition to avoid excessive looping (2016-04-12 10:16:08 -0700)
>
> ----------------------------------------------------------------
> Xen 2016/04/20
>
> ----------------------------------------------------------------
> Wei Liu (1):
> xenfb: use the correct condition to avoid excessive looping
>
> hw/display/xenfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-20 15:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-20 11:14 [Qemu-devel] [PULL for-2.6 0/1] tags/xen-2016-04-20 Stefano Stabellini
2016-04-20 11:15 ` [Qemu-devel] [PULL for-2.6 1/1] xenfb: use the correct condition to avoid excessive looping Stefano Stabellini
2016-04-20 15:43 ` [Qemu-devel] [PULL for-2.6 0/1] tags/xen-2016-04-20 Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).