qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jeff Cody <jcody@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
	Max Reitz <mreitz@redhat.com>,
	qemu-block@nongnu.org, pbonzini@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH for-2.6 3/3] block: Update comment of bdrv_drained_begin
Date: Fri, 22 Apr 2016 14:35:07 +0800	[thread overview]
Message-ID: <1461306907-2837-4-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1461306907-2837-1-git-send-email-famz@redhat.com>

The limitation should be documented. Removing it is a post 2.6
material.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 include/block/block.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/block/block.h b/include/block/block.h
index 3a73137..bb67652 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -530,6 +530,11 @@ void bdrv_flush_io_queue(BlockDriverState *bs);
  * this doesn't block timers or coroutines from submitting more requests, which
  * means block_job_pause is still necessary.
  *
+ * for now this only affacts the aio event loops (namely the data-plane
+ * iothreads and nested aio_poll() calls in block layer).  Specifically, the
+ * main loop can still dispatch external events, even after bdrv_drained_begin
+ * is called.
+ *
  * This function can be recursive.
  */
 void bdrv_drained_begin(BlockDriverState *bs);
-- 
2.8.0

  parent reply	other threads:[~2016-04-22  6:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22  6:35 [Qemu-devel] [PATCH for-2.6 0/3] block: Fix assertion failure at mirror exit Fam Zheng
2016-04-22  6:35 ` [Qemu-devel] [PATCH for-2.6 1/3] mirror: Extract mirror_replace Fam Zheng
2016-04-22  6:35 ` [Qemu-devel] [PATCH for-2.6 2/3] mirror: Skip BH for mirror_exit if in main loop Fam Zheng
2016-04-22  9:37   ` Fam Zheng
2016-04-22  6:35 ` Fam Zheng [this message]
2016-04-22  6:46 ` [Qemu-devel] [PATCH for-2.6 0/3] block: Fix assertion failure at mirror exit Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461306907-2837-4-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).