From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1atUgP-0001yv-Pg for qemu-devel@nongnu.org; Fri, 22 Apr 2016 02:35:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1atUgO-0000Wu-VI for qemu-devel@nongnu.org; Fri, 22 Apr 2016 02:35:17 -0400 From: Fam Zheng Date: Fri, 22 Apr 2016 14:35:07 +0800 Message-Id: <1461306907-2837-4-git-send-email-famz@redhat.com> In-Reply-To: <1461306907-2837-1-git-send-email-famz@redhat.com> References: <1461306907-2837-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH for-2.6 3/3] block: Update comment of bdrv_drained_begin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jeff Cody , Kevin Wolf , Max Reitz , qemu-block@nongnu.org, pbonzini@redhat.com, stefanha@redhat.com The limitation should be documented. Removing it is a post 2.6 material. Signed-off-by: Fam Zheng --- include/block/block.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/block/block.h b/include/block/block.h index 3a73137..bb67652 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -530,6 +530,11 @@ void bdrv_flush_io_queue(BlockDriverState *bs); * this doesn't block timers or coroutines from submitting more requests, which * means block_job_pause is still necessary. * + * for now this only affacts the aio event loops (namely the data-plane + * iothreads and nested aio_poll() calls in block layer). Specifically, the + * main loop can still dispatch external events, even after bdrv_drained_begin + * is called. + * * This function can be recursive. */ void bdrv_drained_begin(BlockDriverState *bs); -- 2.8.0