qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	Jeff Cody <jcody@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
	Max Reitz <mreitz@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH v2 for-2.6 3/5] virtio: Mark host notifiers as external
Date: Fri, 22 Apr 2016 18:56:02 +0800	[thread overview]
Message-ID: <1461322564-17440-4-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1461322564-17440-1-git-send-email-famz@redhat.com>

The effect of this change is the block layer drained section can work,
for example when mirror job is being completed.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 hw/virtio/virtio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index fffa09f..30ede3d 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -1829,10 +1829,10 @@ void virtio_queue_set_host_notifier_fd_handler(VirtQueue *vq, bool assign,
                                                bool set_handler)
 {
     if (assign && set_handler) {
-        event_notifier_set_handler(&vq->host_notifier, false,
+        event_notifier_set_handler(&vq->host_notifier, true,
                                    virtio_queue_host_notifier_read);
     } else {
-        event_notifier_set_handler(&vq->host_notifier, false, NULL);
+        event_notifier_set_handler(&vq->host_notifier, true, NULL);
     }
     if (!assign) {
         /* Test and clear notifier before after disabling event,
-- 
2.8.0

  parent reply	other threads:[~2016-04-22 10:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 10:55 [Qemu-devel] [PATCH v2 for-2.6 0/5] block: Fix assertion failure at mirror exit Fam Zheng
2016-04-22 10:56 ` [Qemu-devel] [PATCH v2 for-2.6 1/5] iohandler: Introduce iohandler_get_aio_context Fam Zheng
2016-04-22 13:46   ` Michael S. Tsirkin
2016-04-22 10:56 ` [Qemu-devel] [PATCH v2 for-2.6 2/5] event-notifier: Add "is_external" parameter Fam Zheng
2016-04-22 13:44   ` Michael S. Tsirkin
2016-04-22 10:56 ` Fam Zheng [this message]
2016-04-22 13:44   ` [Qemu-devel] [PATCH v2 for-2.6 3/5] virtio: Mark host notifiers as external Michael S. Tsirkin
2016-04-22 10:56 ` [Qemu-devel] [PATCH v2 for-2.6 4/5] aio-posix: Skip external nodes in aio_dispatch Fam Zheng
2016-04-22 11:38   ` Kevin Wolf
2016-04-22 11:44     ` Fam Zheng
2016-04-22 10:56 ` [Qemu-devel] [PATCH v2 for-2.6 5/5] mirror: Workaround for unexpected iohandler events during completion Fam Zheng
2016-04-22 13:49 ` [Qemu-devel] [PATCH v2 for-2.6 0/5] block: Fix assertion failure at mirror exit Michael S. Tsirkin
2016-04-22 13:58   ` Fam Zheng
2016-04-22 13:58   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461322564-17440-4-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).