qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Fedorov <sergey.fedorov@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Sergey Fedorov" <serge.fdrv@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Sergey Fedorov" <sergey.fedorov@linaro.org>,
	"Blue Swirl" <blauwirbel@gmail.com>
Subject: [Qemu-devel] [PATCH v2 09/11] tcg/sparc: Make direct jump patching thread-safe
Date: Fri, 22 Apr 2016 19:08:51 +0300	[thread overview]
Message-ID: <1461341333-19646-10-git-send-email-sergey.fedorov@linaro.org> (raw)
In-Reply-To: <1461341333-19646-1-git-send-email-sergey.fedorov@linaro.org>

From: Sergey Fedorov <serge.fdrv@gmail.com>

Ensure direct jump patching in SPARC is atomic by using
atomic_read()/atomic_set() for code patching.

Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---

Changes in v2:
 * Use deposit32() to put displacement into call instruction

 tcg/sparc/tcg-target.inc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tcg/sparc/tcg-target.inc.c b/tcg/sparc/tcg-target.inc.c
index 54df1bc42432..3b54fbd22760 100644
--- a/tcg/sparc/tcg-target.inc.c
+++ b/tcg/sparc/tcg-target.inc.c
@@ -1647,6 +1647,6 @@ void tb_set_jmp_target1(uintptr_t jmp_addr, uintptr_t addr)
        the code_gen_buffer can't be larger than 2GB.  */
     assert(disp == (int32_t)disp);
 
-    *ptr = CALL | (uint32_t)disp >> 2;
+    atomic_set(ptr, deposit32(CALL, 0, 30, disp >> 2));
     flush_icache_range(jmp_addr, jmp_addr + 4);
 }
-- 
2.8.1

  parent reply	other threads:[~2016-04-22 16:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 16:08 [Qemu-devel] [PATCH v2 00/11] tcg: Make direct jump patching thread-safe Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 01/11] include/qemu/osdep.h: Add a macro to check for alignment Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 02/11] include/qemu/osdep.h: Add macros for pointer alignment Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 03/11] tci: Make direct jump patching thread-safe Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 04/11] tcg/ppc: " Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 05/11] tcg/i386: " Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 06/11] tcg/s390: " Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 07/11] tcg/arm: " Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 08/11] tcg/aarch64: " Sergey Fedorov
2016-04-22 16:08 ` Sergey Fedorov [this message]
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 10/11] tcg/mips: " Sergey Fedorov
2016-04-22 16:47   ` Aurelien Jarno
2016-04-22 16:51     ` Aurelien Jarno
2016-04-22 17:00       ` Sergey Fedorov
2016-04-22 18:27         ` Aurelien Jarno
2016-04-22 16:56     ` Sergey Fedorov
2016-04-22 16:08 ` [Qemu-devel] [PATCH v2 11/11] tcg: Note requirement on atomic direct jump patching Sergey Fedorov
2016-04-24 21:36 ` [Qemu-devel] [PATCH v2 00/11] tcg: Make direct jump patching thread-safe Richard Henderson
2016-04-25  9:44   ` Sergey Fedorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461341333-19646-10-git-send-email-sergey.fedorov@linaro.org \
    --to=sergey.fedorov@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=blauwirbel@gmail.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=serge.fdrv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).