From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56583)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1auxeO-0007gT-Mi
	for qemu-devel@nongnu.org; Tue, 26 Apr 2016 03:43:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1auxeL-000293-3c
	for qemu-devel@nongnu.org; Tue, 26 Apr 2016 03:43:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36336)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1auxeK-00028w-UC
	for qemu-devel@nongnu.org; Tue, 26 Apr 2016 03:43:13 -0400
Message-ID: <1461656589.20704.8.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 26 Apr 2016 09:43:09 +0200
In-Reply-To: <1461330148-21393-1-git-send-email-rjones@redhat.com>
References: <1461330148-21393-1-git-send-email-rjones@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg
 DMA version
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, ehabkost@redhat.com, rth@twiddle.net, pbonzini@redhat.com, marc.mari.barcelo@gmail.com, stefanha@redhat.com, lersek@redhat.com

On Fr, 2016-04-22 at 14:02 +0100, Richard W.M. Jones wrote:
> v4 -> v5:
>=20
>  * Fix the initrd loading problem by fixing the get_e801_addr
>    function so it really reads the values from the BIOS.
>=20
> Previously the function always returned 16MB, and so it only happened
> to work for initrd sizes < ~15MB, and broke for anything larger.  Now
> the function is fixed, I tested it on 20MB & 350KB initrds and it
> worked for both.

Can confirm it works, and with a big initramfs it is a very noticable
speedup.

>  * Fix the Win32 cross-compiler issue by making the 'ld -m' (emulator)
>    option conditional on CONFIG_WIN32.
>=20
> This change was not tested with the cross-compiler.  Gerd, could you
> see if this fixes things?

Yes, it builds fine now.

Only thing I've noticed is that I have to manually copy the rom to
pc-bios/, I guess we want place a pre-compiled binary there like we do
for the other option roms.

cheers,
  Gerd