From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avtZb-0002lJ-2L for qemu-devel@nongnu.org; Thu, 28 Apr 2016 17:34:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avtZa-0005SC-0C for qemu-devel@nongnu.org; Thu, 28 Apr 2016 17:34:10 -0400 Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:35132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avtZZ-0005Rq-PK for qemu-devel@nongnu.org; Thu, 28 Apr 2016 17:34:09 -0400 Received: by mail-lf0-x234.google.com with SMTP id c126so111929453lfb.2 for ; Thu, 28 Apr 2016 14:34:09 -0700 (PDT) From: Sergey Fedorov Date: Fri, 29 Apr 2016 00:33:51 +0300 Message-Id: <1461879235-7694-7-git-send-email-sergey.fedorov@linaro.org> In-Reply-To: <1461879235-7694-1-git-send-email-sergey.fedorov@linaro.org> References: <1461879235-7694-1-git-send-email-sergey.fedorov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v5 06/10] tcg: Rename tb_jmp_remove() to tb_remove_from_jmp_list() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Sergey Fedorov , Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Sergey Fedorov From: Sergey Fedorov tb_jmp_remove() was only used to remove the TB from a list of all TBs jumping to the same TB which is n-th jump destination of the given TB. Put a comment briefly describing the function behavior and rename it to better reflect its purpose. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée --- translate-all.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/translate-all.c b/translate-all.c index 1dc1a73c1d55..5e057baaa346 100644 --- a/translate-all.c +++ b/translate-all.c @@ -924,7 +924,8 @@ static inline void tb_page_remove(TranslationBlock **ptb, TranslationBlock *tb) } } -static inline void tb_jmp_remove(TranslationBlock *tb, int n) +/* remove the TB from a list of TBs jumping to the n-th jump target of the TB */ +static inline void tb_remove_from_jmp_list(TranslationBlock *tb, int n) { TranslationBlock *tb1; uintptr_t *ptb, ntb; @@ -998,8 +999,8 @@ void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr) } /* suppress this TB from the two jump lists */ - tb_jmp_remove(tb, 0); - tb_jmp_remove(tb, 1); + tb_remove_from_jmp_list(tb, 0); + tb_remove_from_jmp_list(tb, 1); /* suppress any remaining jumps to this TB */ tb1 = tb->jmp_list_first; -- 2.8.1