From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avzy8-0007NT-JC for qemu-devel@nongnu.org; Fri, 29 Apr 2016 00:23:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avzy6-0000v2-Ok for qemu-devel@nongnu.org; Fri, 29 Apr 2016 00:23:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avzy6-0000ut-KJ for qemu-devel@nongnu.org; Fri, 29 Apr 2016 00:23:54 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 587838F515 for ; Fri, 29 Apr 2016 04:23:54 +0000 (UTC) From: Eric Blake Date: Thu, 28 Apr 2016 22:23:37 -0600 Message-Id: <1461903820-3092-17-git-send-email-eblake@redhat.com> In-Reply-To: <1461903820-3092-1-git-send-email-eblake@redhat.com> References: <1461903820-3092-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH v3 16/18] sockets: Use new QAPI cloning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, famz@redhat.com, "Daniel P. Berrange" , Gerd Hoffmann , Paolo Bonzini Rather than rolling our own clone via an expensive conversion in and back out of QObject, use the generated QAPI version. Signed-off-by: Eric Blake --- v3: new patch --- util/qemu-sockets.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 2a2c524..6b70944 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -1129,25 +1129,5 @@ SocketAddress *socket_remote_address(int fd, Error **errp) void qapi_copy_SocketAddress(SocketAddress **p_dest, SocketAddress *src) { - QmpOutputVisitor *qov; - QmpInputVisitor *qiv; - Visitor *ov, *iv; - QObject *obj; - - *p_dest = NULL; - - qov = qmp_output_visitor_new(); - ov = qmp_output_get_visitor(qov); - visit_type_SocketAddress(ov, NULL, &src, &error_abort); - obj = qmp_output_get_qobject(qov); - qmp_output_visitor_cleanup(qov); - if (!obj) { - return; - } - - qiv = qmp_input_visitor_new(obj, true); - iv = qmp_input_get_visitor(qiv); - visit_type_SocketAddress(iv, NULL, p_dest, &error_abort); - qmp_input_visitor_cleanup(qiv); - qobject_decref(obj); + *p_dest = qapi_SocketAddress_clone(src); } -- 2.5.5