From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>
Subject: [Qemu-devel] [PATCH v4 07/14] m25p80: Switch to byte-based block access
Date: Fri, 29 Apr 2016 14:08:29 -0600 [thread overview]
Message-ID: <1461960516-4717-8-git-send-email-eblake@redhat.com> (raw)
In-Reply-To: <1461960516-4717-1-git-send-email-eblake@redhat.com>
Sector-based blk_read() should die; switch to byte-based
blk_pread() instead.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
Not compile tested - I'm not sure what else I'd need in my environment
to actually test this one. I have:
Fedora 23, dnf builddep qemu
./configure --enable-kvm --enable-system --disable-user --target-list=x86_64-softmmu,ppc64-softmmu --enable-debug
---
hw/block/m25p80.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 906b712..01c51a2 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -907,8 +907,7 @@ static int m25p80_init(SSISlave *ss)
s->storage = blk_blockalign(s->blk, s->size);
/* FIXME: Move to late init */
- if (blk_read(s->blk, 0, s->storage,
- DIV_ROUND_UP(s->size, BDRV_SECTOR_SIZE))) {
+ if (blk_pread(s->blk, 0, s->storage, s->size)) {
fprintf(stderr, "Failed to initialize SPI flash!\n");
return 1;
}
--
2.5.5
next prev parent reply other threads:[~2016-04-29 20:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 20:08 [Qemu-devel] [PATCH v4 00/14] block: kill sector-based blk_write/read Eric Blake
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 01/14] block: Allow BDRV_REQ_FUA through blk_pwrite() Eric Blake
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 02/14] fdc: Switch to byte-based block access Eric Blake
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 03/14] nand: " Eric Blake
2016-05-02 15:35 ` Kevin Wolf
2016-05-02 21:09 ` Eric Blake
2016-05-03 7:45 ` Kevin Wolf
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 04/14] onenand: " Eric Blake
2016-05-02 15:35 ` Kevin Wolf
2016-05-02 21:16 ` Eric Blake
2016-05-02 21:29 ` Eric Blake
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 05/14] pflash: " Eric Blake
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 06/14] sd: " Eric Blake
2016-05-02 15:35 ` Kevin Wolf
2016-04-29 20:08 ` Eric Blake [this message]
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 08/14] atapi: " Eric Blake
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 09/14] nbd: " Eric Blake
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 10/14] qemu-img: " Eric Blake
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 11/14] qemu-io: " Eric Blake
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 12/14] block: Switch blk_read_unthrottled() to byte interface Eric Blake
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 13/14] block: Switch blk_write_zeroes() " Eric Blake
2016-04-29 23:21 ` Eric Blake
2016-04-29 20:08 ` [Qemu-devel] [PATCH v4 14/14] block: Kill blk_write(), blk_read() Eric Blake
2016-05-02 7:27 ` [Qemu-devel] [PATCH v4 00/14] block: kill sector-based blk_write/read Kevin Wolf
2016-05-02 14:12 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461960516-4717-8-git-send-email-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).