From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axD1u-0003Wu-IN for qemu-devel@nongnu.org; Mon, 02 May 2016 08:32:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axD1i-00080A-SF for qemu-devel@nongnu.org; Mon, 02 May 2016 08:32:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axD1i-0007xe-NZ for qemu-devel@nongnu.org; Mon, 02 May 2016 08:32:38 -0400 Message-ID: <1462192343.20597.22.camel@redhat.com> From: Gerd Hoffmann Date: Mon, 02 May 2016 14:32:23 +0200 In-Reply-To: <5710BDF9.30904@redhat.com> References: <1460702609-25971-1-git-send-email-kraxel@redhat.com> <5710BDF9.30904@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Revert "acpi: mark PMTIMER as unlocked" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Peter Maydell Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Igor Mammedov On Fr, 2016-04-15 at 12:10 +0200, Paolo Bonzini wrote: >=20 > On 15/04/2016 08:43, Gerd Hoffmann wrote: > > This reverts commit 7070e085d490c396f9237c8f10bf8b6e69cd0066. > >=20 > > Commit message claims locking is not needed, but that appears > > to not be true, seabios ehci driver runs into timekeeping problems > > with this, see > > https://bugzilla.redhat.com/show_bug.cgi?id=3D1322713 >=20 > I need to look into it further, because for example the same problem > would happen if you moved the PMTIMER to the hypervisor (Xen does this). > But for now this is the right fix, I agree. Peter, can you pick up this one for 2.6? thanks, Gerd