* [Qemu-devel] [PATCH] Revert "acpi: mark PMTIMER as unlocked"
@ 2016-04-15 6:43 Gerd Hoffmann
2016-04-15 10:10 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Gerd Hoffmann @ 2016-04-15 6:43 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Gerd Hoffmann, Michael S. Tsirkin, Igor Mammedov
This reverts commit 7070e085d490c396f9237c8f10bf8b6e69cd0066.
Commit message claims locking is not needed, but that appears
to not be true, seabios ehci driver runs into timekeeping problems
with this, see
https://bugzilla.redhat.com/show_bug.cgi?id=1322713
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/acpi/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index 7925a1a..6a2f452 100644
--- a/hw/acpi/core.c
+++ b/hw/acpi/core.c
@@ -536,7 +536,6 @@ void acpi_pm_tmr_init(ACPIREGS *ar, acpi_update_sci_fn update_sci,
ar->tmr.timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, acpi_pm_tmr_timer, ar);
memory_region_init_io(&ar->tmr.io, memory_region_owner(parent),
&acpi_pm_tmr_ops, ar, "acpi-tmr", 4);
- memory_region_clear_global_locking(&ar->tmr.io);
memory_region_add_subregion(parent, 8, &ar->tmr.io);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] Revert "acpi: mark PMTIMER as unlocked"
2016-04-15 6:43 [Qemu-devel] [PATCH] Revert "acpi: mark PMTIMER as unlocked" Gerd Hoffmann
@ 2016-04-15 10:10 ` Paolo Bonzini
2016-05-02 12:32 ` Gerd Hoffmann
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2016-04-15 10:10 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: Michael S. Tsirkin, Igor Mammedov
On 15/04/2016 08:43, Gerd Hoffmann wrote:
> This reverts commit 7070e085d490c396f9237c8f10bf8b6e69cd0066.
>
> Commit message claims locking is not needed, but that appears
> to not be true, seabios ehci driver runs into timekeeping problems
> with this, see
> https://bugzilla.redhat.com/show_bug.cgi?id=1322713
I need to look into it further, because for example the same problem
would happen if you moved the PMTIMER to the hypervisor (Xen does this).
But for now this is the right fix, I agree.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Revert "acpi: mark PMTIMER as unlocked"
2016-04-15 10:10 ` Paolo Bonzini
@ 2016-05-02 12:32 ` Gerd Hoffmann
2016-05-02 16:19 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Gerd Hoffmann @ 2016-05-02 12:32 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell
Cc: qemu-devel, Michael S. Tsirkin, Igor Mammedov
On Fr, 2016-04-15 at 12:10 +0200, Paolo Bonzini wrote:
>
> On 15/04/2016 08:43, Gerd Hoffmann wrote:
> > This reverts commit 7070e085d490c396f9237c8f10bf8b6e69cd0066.
> >
> > Commit message claims locking is not needed, but that appears
> > to not be true, seabios ehci driver runs into timekeeping problems
> > with this, see
> > https://bugzilla.redhat.com/show_bug.cgi?id=1322713
>
> I need to look into it further, because for example the same problem
> would happen if you moved the PMTIMER to the hypervisor (Xen does this).
> But for now this is the right fix, I agree.
Peter, can you pick up this one for 2.6?
thanks,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Revert "acpi: mark PMTIMER as unlocked"
2016-05-02 12:32 ` Gerd Hoffmann
@ 2016-05-02 16:19 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2016-05-02 16:19 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: Paolo Bonzini, QEMU Developers, Michael S. Tsirkin, Igor Mammedov
On 2 May 2016 at 13:32, Gerd Hoffmann <kraxel@redhat.com> wrote:
> On Fr, 2016-04-15 at 12:10 +0200, Paolo Bonzini wrote:
>>
>> On 15/04/2016 08:43, Gerd Hoffmann wrote:
>> > This reverts commit 7070e085d490c396f9237c8f10bf8b6e69cd0066.
>> >
>> > Commit message claims locking is not needed, but that appears
>> > to not be true, seabios ehci driver runs into timekeeping problems
>> > with this, see
>> > https://bugzilla.redhat.com/show_bug.cgi?id=1322713
>>
>> I need to look into it further, because for example the same problem
>> would happen if you moved the PMTIMER to the hypervisor (Xen does this).
>> But for now this is the right fix, I agree.
>
> Peter, can you pick up this one for 2.6?
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-02 16:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-15 6:43 [Qemu-devel] [PATCH] Revert "acpi: mark PMTIMER as unlocked" Gerd Hoffmann
2016-04-15 10:10 ` Paolo Bonzini
2016-05-02 12:32 ` Gerd Hoffmann
2016-05-02 16:19 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).