From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axD46-00073A-2g for qemu-devel@nongnu.org; Mon, 02 May 2016 08:35:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axD3l-0008WB-7t for qemu-devel@nongnu.org; Mon, 02 May 2016 08:35:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axD3l-0008SX-3k for qemu-devel@nongnu.org; Mon, 02 May 2016 08:34:45 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 086CA8111B for ; Mon, 2 May 2016 12:34:34 +0000 (UTC) From: Igor Mammedov Date: Mon, 2 May 2016 14:33:32 +0200 Message-Id: <1462192431-146342-24-git-send-email-imammedo@redhat.com> In-Reply-To: <1462192431-146342-1-git-send-email-imammedo@redhat.com> References: <1462192431-146342-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [RFC 23/42] tests: pc-cpu-test: turn on cpu-hotplug explicily List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com, ehabkost@redhat.com, marcel@redhat.com, eblake@redhat.com, armbru@redhat.com, drjones@redhat.com Machine types before 2.7 have legacy CPU hotplug enabled by defaut to not regress existing setups where it's always enabled. But since 2.7 CPU hotplug is disabled y default and requires explicit enabling using 'cpu-hotplug' parameter in '-machine' option. So turn it on for cpu-hotplug testcase to allow it test 2.7 and later machine types. Fixes following failure: /x86_64/cpu/pc-q35-2.7/add/1x3x2&maxcpus=12: ** ERROR:tests/pc-cpu-test.c:44:test_pc_with_cpu_add: assertion failed: (!qdict_haskey(response, "error")) Signed-off-by: Igor Mammedov --- tests/pc-cpu-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/pc-cpu-test.c b/tests/pc-cpu-test.c index 6b34ca5..5c9fd1e 100644 --- a/tests/pc-cpu-test.c +++ b/tests/pc-cpu-test.c @@ -31,7 +31,7 @@ static void test_pc_with_cpu_add(gconstpointer data) QDict *response; unsigned int i; - args = g_strdup_printf("-machine %s -cpu %s " + args = g_strdup_printf("-machine %s,cpu-hotplug=on -cpu %s " "-smp sockets=%u,cores=%u,threads=%u,maxcpus=%u", s->machine, s->cpu_model, s->sockets, s->cores, s->threads, s->maxcpus); -- 1.8.3.1