* [Qemu-devel] [PATCH v2] fixup! tcg/mips: Make direct jump patching thread-safe
@ 2016-05-02 17:35 Sergey Fedorov
2016-05-02 17:41 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Sergey Fedorov @ 2016-05-02 17:35 UTC (permalink / raw)
To: qemu-devel
Cc: Sergey Fedorov, Sergey Fedorov, Aurelien Jarno, Richard Henderson
From: Sergey Fedorov <serge.fdrv@gmail.com>
Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
---
This patch is based on a commit:
e601ccb62016 ("cpu-exec: Move TB chaining into tb_find_fast()")
from:
https://github.com/rth7680/qemu.git tcg-next
tcg/mips/tcg-target.inc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c
index b0440b9c5a79..50e98ea63a73 100644
--- a/tcg/mips/tcg-target.inc.c
+++ b/tcg/mips/tcg-target.inc.c
@@ -1885,6 +1885,6 @@ static void tcg_target_init(TCGContext *s)
void tb_set_jmp_target1(uintptr_t jmp_addr, uintptr_t addr)
{
- atomic_set(ptr, deposit32(OPC_J, 0, 26, addr >> 2));
+ atomic_set((uint32_t *)jmp_addr, deposit32(OPC_J, 0, 26, addr >> 2));
flush_icache_range(jmp_addr, jmp_addr + 4);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] fixup! tcg/mips: Make direct jump patching thread-safe
2016-05-02 17:35 [Qemu-devel] [PATCH v2] fixup! tcg/mips: Make direct jump patching thread-safe Sergey Fedorov
@ 2016-05-02 17:41 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2016-05-02 17:41 UTC (permalink / raw)
To: Sergey Fedorov, qemu-devel; +Cc: Sergey Fedorov, Aurelien Jarno
On 05/02/2016 07:35 AM, Sergey Fedorov wrote:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
> ---
>
> This patch is based on a commit:
>
> e601ccb62016 ("cpu-exec: Move TB chaining into tb_find_fast()")
>
> from:
>
> https://github.com/rth7680/qemu.git tcg-next
>
> tcg/mips/tcg-target.inc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c
> index b0440b9c5a79..50e98ea63a73 100644
> --- a/tcg/mips/tcg-target.inc.c
> +++ b/tcg/mips/tcg-target.inc.c
> @@ -1885,6 +1885,6 @@ static void tcg_target_init(TCGContext *s)
>
> void tb_set_jmp_target1(uintptr_t jmp_addr, uintptr_t addr)
> {
> - atomic_set(ptr, deposit32(OPC_J, 0, 26, addr >> 2));
> + atomic_set((uint32_t *)jmp_addr, deposit32(OPC_J, 0, 26, addr >> 2));
> flush_icache_range(jmp_addr, jmp_addr + 4);
> }
>
Thanks. Will fix.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-02 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-02 17:35 [Qemu-devel] [PATCH v2] fixup! tcg/mips: Make direct jump patching thread-safe Sergey Fedorov
2016-05-02 17:41 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).