From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axOWC-0005e5-B1 for qemu-devel@nongnu.org; Mon, 02 May 2016 20:48:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axOVx-000551-TJ for qemu-devel@nongnu.org; Mon, 02 May 2016 20:48:46 -0400 From: Christopher Friedt Date: Mon, 2 May 2016 20:47:58 -0400 Message-Id: <1462236478-61645-3-git-send-email-chrisfriedt@gmail.com> In-Reply-To: <1462236478-61645-1-git-send-email-chrisfriedt@gmail.com> References: <1462236478-61645-1-git-send-email-chrisfriedt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------2.6.4 (Apple Git-63)" Subject: [Qemu-devel] [PATCH 2/2] Remove unnecessary CONFIG_EVENTFD preprocessor conditional to satisfy link List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: famz@redhat.com, mst@redhat.com Cc: Christopher Friedt , qemu-devel@nongnu.org, qemu-trivial@nongnu.org This is a multi-part message in MIME format. --------------2.6.4 (Apple Git-63) Content-Type: text/plain; charset=UTF-8; format=fixed Content-Transfer-Encoding: 8bit The file ivshmem.c unconditionally references event_notifier_init_fd() in util/event_notifier-posix.c, even if CONFIG_EVENTFD is not defined. On platforms where CONFIG_POSIX is defined, but CONFIG_EVENTFD is not defined, that results in an undefined symbol referenced from ivshmem.c and the link fails. That applies to Mac OS X, but possibly other BSD-based distros. Note: there is nothing specific to eventfd inside and event_notifier_init() also fails unconditionally if CONFIG_EVENTFD is not defined. Signed-off-by: Christopher Friedt --- util/event_notifier-posix.c | 2 -- 1 file changed, 2 deletions(-) --------------2.6.4 (Apple Git-63) Content-Type: text/x-patch; name="0002-Remove-unnecessary-CONFIG_EVENTFD-preprocessor-condi.patch" Content-Transfer-Encoding: 8bit Content-Disposition: inline; filename="0002-Remove-unnecessary-CONFIG_EVENTFD-preprocessor-condi.patch" diff --git a/util/event_notifier-posix.c b/util/event_notifier-posix.c index c1f0d79..c9bb34d 100644 --- a/util/event_notifier-posix.c +++ b/util/event_notifier-posix.c @@ -21,7 +21,6 @@ #include #endif -#ifdef CONFIG_EVENTFD /* * Initialize @e with existing file descriptor @fd. * @fd must be a genuine eventfd object, emulation with pipe won't do. @@ -31,7 +30,6 @@ void event_notifier_init_fd(EventNotifier *e, int fd) e->rfd = fd; e->wfd = fd; } -#endif int event_notifier_init(EventNotifier *e, int active) { --------------2.6.4 (Apple Git-63)--