From: Christopher Friedt <chrisfriedt@gmail.com>
To: famz@redhat.com, mst@redhat.com
Cc: Christopher Friedt <chrisfriedt@gmail.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: [Qemu-devel] [PATCH 1/2] [RESENT-INLINE] Use libtool instead of ar to create static libraries on Darwin.
Date: Mon, 2 May 2016 21:01:04 -0400 [thread overview]
Message-ID: <1462237265-61763-2-git-send-email-chrisfriedt@gmail.com> (raw)
In-Reply-To: <1462237265-61763-1-git-send-email-chrisfriedt@gmail.com>
Currently, at least on Mac OS X 10.11.4 (El Capitan), Qemu fails to build for a few reasons.
One of those reasons is that Apple's ld (at least ld64) does not properly process archive files created with ar (even Apple's ar).
After some RTFM'ing, I came upon this tidbit, which is unfortunate. Luckily, autotools packages are not broken.
"Libtool with -static is intended to replace ar(5) and ranlib."
http://www.manpages.info/macosx/libtool.1.html
In any case, this change takes Apple's recommendations into account and allows Qemu to build on Mac OS X El Capitan.
Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
---
rules.mak | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/rules.mak b/rules.mak
index d1ff311..44421af 100644
--- a/rules.mak
+++ b/rules.mak
@@ -105,7 +105,11 @@ modules:
$(call LINK,$(filter %.o %.a %.mo, $^))
%.a:
+ifeq ($(shell uname),Darwin)
+ $(call quiet-command,rm -f $@ && libtool -static -o $@ $^," libtool $(TARGET_DIR)$@")
+else
$(call quiet-command,rm -f $@ && $(AR) rcs $@ $^," AR $(TARGET_DIR)$@")
+endif
quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1))
--
2.6.4 (Apple Git-63)
next prev parent reply other threads:[~2016-05-03 1:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 1:01 [Qemu-devel] [PATCH 0/2][RESENT-INLINE] Resolve link errors on Mac OS X Christopher Friedt
2016-05-03 1:01 ` Christopher Friedt [this message]
2016-05-03 1:01 ` [Qemu-devel] [PATCH 2/2] [RESENT-INLINE] Remove unnecessary CONFIG_EVENTFD preprocessor conditional to satisfy link Christopher Friedt
2016-05-03 6:59 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462237265-61763-2-git-send-email-chrisfriedt@gmail.com \
--to=chrisfriedt@gmail.com \
--cc=famz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).