From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v5 09/14] nbd: Switch to byte-based block access
Date: Tue, 3 May 2016 09:42:41 -0600 [thread overview]
Message-ID: <1462290166-32584-10-git-send-email-eblake@redhat.com> (raw)
In-Reply-To: <1462290166-32584-1-git-send-email-eblake@redhat.com>
Sector-based blk_read() should die; switch to byte-based
blk_pread() instead.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
qemu-nbd.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index c55b40f..c07ceef 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -159,12 +159,13 @@ static int find_partition(BlockBackend *blk, int partition,
off_t *offset, off_t *size)
{
struct partition_record mbr[4];
- uint8_t data[512];
+ uint8_t data[BDRV_SECTOR_SIZE];
int i;
int ext_partnum = 4;
int ret;
- if ((ret = blk_read(blk, 0, data, 1)) < 0) {
+ ret = blk_pread(blk, 0, data, sizeof(data));
+ if (ret < 0) {
error_report("error while reading: %s", strerror(-ret));
exit(EXIT_FAILURE);
}
@@ -182,10 +183,12 @@ static int find_partition(BlockBackend *blk, int partition,
if (mbr[i].system == 0xF || mbr[i].system == 0x5) {
struct partition_record ext[4];
- uint8_t data1[512];
+ uint8_t data1[BDRV_SECTOR_SIZE];
int j;
- if ((ret = blk_read(blk, mbr[i].start_sector_abs, data1, 1)) < 0) {
+ ret = blk_pread(blk, mbr[i].start_sector_abs << BDRV_SECTOR_BITS,
+ data1, sizeof(data1));
+ if (ret < 0) {
error_report("error while reading: %s", strerror(-ret));
exit(EXIT_FAILURE);
}
--
2.5.5
next prev parent reply other threads:[~2016-05-03 15:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 15:42 [Qemu-devel] [PATCH v5 00/14] block: kill sector-based blk_write/read Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 01/14] block: Allow BDRV_REQ_FUA through blk_pwrite() Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 02/14] fdc: Switch to byte-based block access Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 03/14] nand: " Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 04/14] onenand: " Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 05/14] pflash: " Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 06/14] sd: " Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 07/14] m25p80: " Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 08/14] atapi: " Eric Blake
2016-05-03 15:42 ` Eric Blake [this message]
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 10/14] qemu-img: " Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 11/14] qemu-io: " Eric Blake
2016-05-04 13:10 ` Kevin Wolf
2016-05-04 14:13 ` Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 12/14] block: Switch blk_read_unthrottled() to byte interface Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 13/14] block: Switch blk_write_zeroes() " Eric Blake
2016-05-03 15:42 ` [Qemu-devel] [PATCH v5 14/14] block: Kill blk_write(), blk_read() Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462290166-32584-10-git-send-email-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).