From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay3CV-0002wf-Rr for qemu-devel@nongnu.org; Wed, 04 May 2016 16:15:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay3CK-0003zQ-1T for qemu-devel@nongnu.org; Wed, 04 May 2016 16:15:10 -0400 Received: from smtp1-g21.free.fr ([2a01:e0c:1:1599::10]:17734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay3CJ-0003rn-QK for qemu-devel@nongnu.org; Wed, 04 May 2016 16:15:03 -0400 From: Laurent Vivier Date: Wed, 4 May 2016 22:12:00 +0200 Message-Id: <1462392752-17703-21-git-send-email-laurent@vivier.eu> In-Reply-To: <1462392752-17703-1-git-send-email-laurent@vivier.eu> References: <1462392752-17703-1-git-send-email-laurent@vivier.eu> Subject: [Qemu-devel] [PATCH 20/52] target-m68k: Remove incorrect clearing of cc_x List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: gerg@uclinux.org, schwab@linux-m68k.org, agraf@suse.de, rth@twiddle.net, Laurent Vivier From: Richard Henderson The CF docs certainly doesnt suggest this is true. Signed-off-by: Richard Henderson Signed-off-by: Laurent Vivier --- target-m68k/helper.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/target-m68k/helper.c b/target-m68k/helper.c index ffed180..9c14d6f 100644 --- a/target-m68k/helper.c +++ b/target-m68k/helper.c @@ -206,19 +206,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op) break; case CC_OP_LOGICB: SET_NZ(dest, int8_t); - goto set_x; break; case CC_OP_LOGICW: SET_NZ(dest, int16_t); - goto set_x; break; case CC_OP_LOGIC: SET_NZ(dest, int32_t); -set_x: - if (!m68k_feature(env, M68K_FEATURE_M68000)) { - /* Unlike m68k, coldfire always clears the overflow bit. */ - env->cc_x = 0; - } break; case CC_OP_ADDB: SET_FLAGS_ADD(int8_t, uint8_t); -- 2.5.5