From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayKHN-000280-7d for qemu-devel@nongnu.org; Thu, 05 May 2016 10:29:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayKHB-00054v-Jh for qemu-devel@nongnu.org; Thu, 05 May 2016 10:29:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayKHB-00051W-FA for qemu-devel@nongnu.org; Thu, 05 May 2016 10:29:13 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 657DB7EBA8 for ; Thu, 5 May 2016 14:29:02 +0000 (UTC) From: "Daniel P. Berrange" Date: Thu, 5 May 2016 15:27:58 +0100 Message-Id: <1462458480-20555-5-git-send-email-berrange@redhat.com> In-Reply-To: <1462458480-20555-1-git-send-email-berrange@redhat.com> References: <1462458480-20555-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH v1 4/6] scripts: set timeout when waiting for qemu monitor connection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Juan Quintela , Amit Shah , "Dr. David Alan Gilbert" , "Daniel P. Berrange" If QEMU fails to launch for some reason, the QEMUMonitorProtocol class accept() method will wait forever in a socket accept call. Set a timeout of 15 seconds so that we fail more gracefully instead of hanging the test script forever Signed-off-by: Daniel P. Berrange --- scripts/qmp/qmp.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py index 70e927e..2d0d926 100644 --- a/scripts/qmp/qmp.py +++ b/scripts/qmp/qmp.py @@ -140,6 +140,7 @@ class QEMUMonitorProtocol: @raise QMPConnectError if the greeting is not received @raise QMPCapabilitiesError if fails to negotiate capabilities """ + self.__sock.settimeout(15) self.__sock, _ = self.__sock.accept() self.__sockfile = self.__sock.makefile() return self.__negotiate_capabilities() -- 2.5.5