From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, quintela@redhat.com
Cc: amit.shah@redhat.com, aarcange@redhat.com, den@openvz.org,
marcel.a@redhat.com, eblake@redhat.com
Subject: [Qemu-devel] [PATCH v3 1/5] Postcopy: Avoid 0 length discards
Date: Fri, 6 May 2016 13:34:15 +0100 [thread overview]
Message-ID: <1462538059-27630-2-git-send-email-dgilbert@redhat.com> (raw)
In-Reply-To: <1462538059-27630-1-git-send-email-dgilbert@redhat.com>
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
The discard code in migration/ram.c would send request for
zero length discards in the case where no discards were needed.
It doesn't appear to have had any bad effect.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
---
migration/ram.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 3f05738..e96c2af 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1557,7 +1557,9 @@ static int postcopy_send_discard_bm_ram(MigrationState *ms,
} else {
discard_length = zero - one;
}
- postcopy_discard_send_range(ms, pds, one, discard_length);
+ if (discard_length) {
+ postcopy_discard_send_range(ms, pds, one, discard_length);
+ }
current = one + discard_length;
} else {
current = one;
--
2.5.5
next prev parent reply other threads:[~2016-05-06 12:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 12:34 [Qemu-devel] [PATCH v3 0/5] postcopy (& 1 test) patch for 2.7 Dr. David Alan Gilbert (git)
2016-05-06 12:34 ` Dr. David Alan Gilbert (git) [this message]
2016-05-06 12:34 ` [Qemu-devel] [PATCH v3 2/5] Migration: Split out ram part of qmp_query_migrate Dr. David Alan Gilbert (git)
2016-05-06 12:34 ` [Qemu-devel] [PATCH v3 3/5] Postcopy: Add stats on page requests Dr. David Alan Gilbert (git)
2016-05-06 12:34 ` [Qemu-devel] [PATCH v3 4/5] test: Postcopy Dr. David Alan Gilbert (git)
2016-05-08 8:26 ` Marcel Apfelbaum
2016-05-06 12:34 ` [Qemu-devel] [PATCH v3 5/5] tests: fix libqtest socket timeouts Dr. David Alan Gilbert (git)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462538059-27630-2-git-send-email-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=aarcange@redhat.com \
--cc=amit.shah@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=marcel.a@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).