From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41240)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b0QvF-0002V4-Fv
	for qemu-devel@nongnu.org; Wed, 11 May 2016 05:59:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b0QvA-0003Mu-EA
	for qemu-devel@nongnu.org; Wed, 11 May 2016 05:59:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33256)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b0QvA-0003Mn-8Q
	for qemu-devel@nongnu.org; Wed, 11 May 2016 05:59:12 -0400
Message-ID: <1462960749.5679.31.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 11 May 2016 11:59:09 +0200
In-Reply-To: <1462958546-22492-1-git-send-email-wangxinxin.wang@huawei.com>
References: <1462958546-22492-1-git-send-email-wangxinxin.wang@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] vga: use vbe_enabled() helper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wang Xin <wangxinxin.wang@huawei.com>
Cc: qemu-devel@nongnu.org

On Mi, 2016-05-11 at 17:22 +0800, Wang Xin wrote:
> Commit bfa0f15 add vbe_enabled() helper, while it forget to replace
> the code in vbe_ioport_write_data().

>          case VBE_DISPI_INDEX_ENABLE:
> -            if ((val & VBE_DISPI_ENABLED) &&
> -                !(s->vbe_regs[VBE_DISPI_INDEX_ENABLE] & VBE_DISPI_ENABLE=
D)) {

I left it there as-is intentionally, because that is the place where VBE
is actually enabled and I think the code is easier to read if the logic
at that location isn't hidden by the helper.

cheers,
  Gerd