From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0SBA-00027F-OL for qemu-devel@nongnu.org; Wed, 11 May 2016 07:19:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0SB4-0004y7-HC for qemu-devel@nongnu.org; Wed, 11 May 2016 07:19:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0SB4-0004x8-CC for qemu-devel@nongnu.org; Wed, 11 May 2016 07:19:42 -0400 From: Gerd Hoffmann Date: Wed, 11 May 2016 13:19:28 +0200 Message-Id: <1462965569-6407-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1462965569-6407-1-git-send-email-kraxel@redhat.com> References: <1462965569-6407-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 2/3] usb-mtp: fix usb_mtp_get_device_info so that libmtp on the guest doesn't complain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Isaac Lozano <109lozanoi@gmail.com>, Gerd Hoffmann From: Isaac Lozano <109lozanoi@gmail.com> If an application uses libmtp on the guest system, it will complain with the warning message: LIBMTP WARNING: VendorExtensionID: ffffffff LIBMTP WARNING: VendorExtensionDesc: (null) LIBMTP WARNING: this typically means the device is PTP (i.e. a camera) but not a MTP device at all. Trying to continue anyway. This is because libmtp expects a MTP Vendor Extension ID of 0x00000006 and a MTP Version of 0x0064. These numbers are taken from Microsoft's MTP Vendor Extension Identification Message page and are what most physical devices show. Signed-off-by: Isaac Lozano <109lozanoi@gmail.com> Reviewed-by: Stefan Hajnoczi Message-id: 1460892593-5908-1-git-send-email-109lozanoi@gmail.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index bda84a6..1be85ae 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -788,8 +788,8 @@ static MTPData *usb_mtp_get_device_info(MTPState *s, MTPControl *c) trace_usb_mtp_op_get_device_info(s->dev.addr); usb_mtp_add_u16(d, 100); - usb_mtp_add_u32(d, 0xffffffff); - usb_mtp_add_u16(d, 0x0101); + usb_mtp_add_u32(d, 0x00000006); + usb_mtp_add_u16(d, 0x0064); usb_mtp_add_wstr(d, L""); usb_mtp_add_u16(d, 0x0000); -- 1.8.3.1