From: Gerd Hoffmann <kraxel@redhat.com>
To: xiaoqiang zhao <zxq_yx_007@163.com>
Cc: qemu-devel@nongnu.org, michael@walle.cc, afaerber@suse.de,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RESEND PATCH v2 3/4] hw/audio: QOM'ify intel-hda
Date: Wed, 11 May 2016 13:27:00 +0200 [thread overview]
Message-ID: <1462966020.5679.33.camel@redhat.com> (raw)
In-Reply-To: <1458205576-21646-4-git-send-email-zxq_yx_007@163.com>
> bus->next_cad = dev->cad + 1;
> - return cdc->init(dev);
> + if (cdc->init(dev) != 0)
> + error_setg(errp, "HDA audio init failed.");
=== checkpatch complains ===
WARNING: braces {} are necessary for all arms of this statement
#25: FILE: hw/audio/intel-hda.c:67:
+ if (cdc->init(dev) != 0)
[...]
cheers,
Gerd
next prev parent reply other threads:[~2016-05-11 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 9:06 [Qemu-devel] [RESEND PATCH v2 0/4] QOM'ify hw/audio files xiaoqiang zhao
2016-03-17 9:06 ` [Qemu-devel] [RESEND PATCH v2 1/4] hw/audio: QOM'ify cs4231.c xiaoqiang zhao
2016-03-17 9:06 ` [Qemu-devel] [RESEND PATCH v2 2/4] hw/audio: QOM cleanup for intel-hda xiaoqiang zhao
2016-03-17 9:06 ` [Qemu-devel] [RESEND PATCH v2 3/4] hw/audio: QOM'ify intel-hda xiaoqiang zhao
2016-05-11 11:27 ` Gerd Hoffmann [this message]
2016-05-11 11:47 ` xiaoqiang zhao
2016-03-17 9:06 ` [Qemu-devel] [RESEND PATCH v2 4/4] hw/audio: QOM'ify milkymist-ac97.c xiaoqiang zhao
2016-05-09 9:03 ` michael
2016-03-29 7:28 ` [Qemu-devel] [RESEND PATCH v2 0/4] QOM'ify hw/audio files zxq_yx_007
2016-05-05 10:42 ` 赵小强
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462966020.5679.33.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=michael@walle.cc \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zxq_yx_007@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).