From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58581)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b0SII-0002ob-H7
	for qemu-devel@nongnu.org; Wed, 11 May 2016 07:27:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b0SIB-0006FI-UQ
	for qemu-devel@nongnu.org; Wed, 11 May 2016 07:27:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53059)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b0SIB-0006FE-Ou
	for qemu-devel@nongnu.org; Wed, 11 May 2016 07:27:03 -0400
Message-ID: <1462966020.5679.33.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 11 May 2016 13:27:00 +0200
In-Reply-To: <1458205576-21646-4-git-send-email-zxq_yx_007@163.com>
References: <1458205576-21646-1-git-send-email-zxq_yx_007@163.com>
	<1458205576-21646-4-git-send-email-zxq_yx_007@163.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [RESEND PATCH v2 3/4] hw/audio: QOM'ify intel-hda
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: xiaoqiang zhao <zxq_yx_007@163.com>
Cc: qemu-devel@nongnu.org, michael@walle.cc, afaerber@suse.de, pbonzini@redhat.com

>      bus->next_cad =3D dev->cad + 1;
> -    return cdc->init(dev);
> +    if (cdc->init(dev) !=3D 0)
> +        error_setg(errp, "HDA audio init failed.");

=3D=3D=3D checkpatch complains =3D=3D=3D
WARNING: braces {} are necessary for all arms of this statement
#25: FILE: hw/audio/intel-hda.c:67:
+    if (cdc->init(dev) !=3D 0)
[...]

cheers,
  Gerd