From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0Tzq-000861-92 for qemu-devel@nongnu.org; Wed, 11 May 2016 09:16:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0Tzh-0005w8-2Z for qemu-devel@nongnu.org; Wed, 11 May 2016 09:16:10 -0400 From: "Daniel P. Berrange" Date: Wed, 11 May 2016 14:15:31 +0100 Message-Id: <1462972533-30608-9-git-send-email-berrange@redhat.com> In-Reply-To: <1462972533-30608-1-git-send-email-berrange@redhat.com> References: <1462972533-30608-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH v4 08/10] nbd: allow an ACL to be set with nbd-server-start QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Eric Blake , Max Reitz , Markus Armbruster , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Paolo Bonzini , qemu-block@nongnu.org, "Daniel P. Berrange" As with the previous patch to qemu-nbd, the nbd-server-start QMP command also needs to be able to specify an ACL when enabling TLS encryption. First the client must create a QAuthZ object instance using the 'object-add' command: { 'execute': 'object-add', 'arguments': { 'qom-type': 'authz-simple', 'id': 'tls0', 'parameters': { 'policy': 'deny', 'rules': [ { 'match': '*CN=fred', 'policy': 'allow' } ] } } } They can then reference this in the new 'tls-acl' parameter when executing the 'nbd-server-start' command. { 'execute': 'nbd-server-start', 'arguments': { 'addr': { 'type': 'inet', 'host': '127.0.0.1', 'port': '9000' }, 'tls-creds': 'tls0', 'tls-acl': 'tlsacl0' } } Signed-off-by: Daniel P. Berrange --- blockdev-nbd.c | 10 +++++++++- hmp.c | 2 +- qapi/block.json | 4 +++- qmp-commands.hx | 2 +- 4 files changed, 14 insertions(+), 4 deletions(-) diff --git a/blockdev-nbd.c b/blockdev-nbd.c index 12cae0e..ae5335e 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @@ -24,6 +24,7 @@ typedef struct NBDServerData { QIOChannelSocket *listen_ioc; int watch; QCryptoTLSCreds *tlscreds; + char *tlsacl; } NBDServerData; static NBDServerData *nbd_server; @@ -45,7 +46,8 @@ static gboolean nbd_accept(QIOChannel *ioc, GIOCondition condition, } nbd_client_new(NULL, cioc, - nbd_server->tlscreds, NULL, + nbd_server->tlscreds, + nbd_server->tlsacl, nbd_client_put); object_unref(OBJECT(cioc)); return TRUE; @@ -65,6 +67,7 @@ static void nbd_server_free(NBDServerData *server) if (server->tlscreds) { object_unref(OBJECT(server->tlscreds)); } + g_free(server->tlsacl); g_free(server); } @@ -101,6 +104,7 @@ static QCryptoTLSCreds *nbd_get_tls_creds(const char *id, Error **errp) void qmp_nbd_server_start(SocketAddress *addr, bool has_tls_creds, const char *tls_creds, + bool has_tls_acl, const char *tls_acl, Error **errp) { if (nbd_server) { @@ -128,6 +132,10 @@ void qmp_nbd_server_start(SocketAddress *addr, } } + if (has_tls_acl) { + nbd_server->tlsacl = g_strdup(tls_acl); + } + nbd_server->watch = qio_channel_add_watch( QIO_CHANNEL(nbd_server->listen_ioc), G_IO_IN, diff --git a/hmp.c b/hmp.c index 2232660..cfd4cd9 100644 --- a/hmp.c +++ b/hmp.c @@ -1803,7 +1803,7 @@ void hmp_nbd_server_start(Monitor *mon, const QDict *qdict) goto exit; } - qmp_nbd_server_start(addr, false, NULL, &local_err); + qmp_nbd_server_start(addr, false, NULL, false, NULL, &local_err); qapi_free_SocketAddress(addr); if (local_err != NULL) { goto exit; diff --git a/qapi/block.json b/qapi/block.json index 937337d..a674865 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -147,6 +147,7 @@ # # @addr: Address on which to listen. # @tls-creds: (optional) ID of the TLS credentials object. Since 2.6 +# @tls-acl: (optional) ID of the QAuthZ authorization object. Since 2.6 # # Returns: error if the server is already running. # @@ -154,7 +155,8 @@ ## { 'command': 'nbd-server-start', 'data': { 'addr': 'SocketAddress', - '*tls-creds': 'str'} } + '*tls-creds': 'str', + '*tls-acl': 'str'} } ## # @nbd-server-add: diff --git a/qmp-commands.hx b/qmp-commands.hx index de896a5..034056d 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -3859,7 +3859,7 @@ EQMP { .name = "nbd-server-start", - .args_type = "addr:q,tls-creds:s?", + .args_type = "addr:q,tls-creds:s?,tls-acl:s?", .mhandler.cmd_new = qmp_marshal_nbd_server_start, }, { -- 2.5.5