[Qemu-devel] [PATCH] fixup! tcg: code_bitmap is not used by user-mode emulation

[Qemu-devel] [PATCH] fixup! tcg: code_bitmap is not used by user-mode emulation

[Sergey Fedorov]

From: Sergey Fedorov <serge.fdrv@gmail.com>

Eliminate 'code_write_count' as well.

Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
---

This series is based on commit
    40f646483a11 (cpu-exec: Remove relic orphaned comment)
from
    git://github.com/rth7680/qemu.git tcg-next

 translate-all.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/translate-all.c b/translate-all.c
index 345b35a3d2a2..b54f47253122 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -72,10 +72,10 @@
 typedef struct PageDesc {
     /* list of TBs intersecting this ram page */
     TranslationBlock *first_tb;
+#ifdef CONFIG_SOFTMMU
     /* in order to optimize self modifying code, we count the number
        of lookups we do to a given page to use a bitmap */
     unsigned int code_write_count;
-#ifdef CONFIG_SOFTMMU
     unsigned long *code_bitmap;
 #else
     unsigned long flags;
@@ -786,8 +786,8 @@ static inline void invalidate_page_bitmap(PageDesc *p)
 #ifdef CONFIG_SOFTMMU
     g_free(p->code_bitmap);
     p->code_bitmap = NULL;
-#endif
     p->code_write_count = 0;
+#endif
 }
 
 /* Set to NULL all the 'first_tb' fields in all PageDescs. */
-- 
1.9.1

Re: [Qemu-devel] [PATCH] fixup! tcg: code_bitmap is not used by user-mode emulation

[Richard Henderson]

On 05/11/2016 06:06 AM, Sergey Fedorov wrote:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
>
> Eliminate 'code_write_count' as well.
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
> ---

Merged.


r~