qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, marc.mari.barcelo@gmail.com,
	ehabkost@redhat.com, mst@redhat.com, kraxel@redhat.com,
	rth@twiddle.net, lersek@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v8 2/3] scripts/signrom.py: Check for magic in option ROMs.
Date: Wed, 11 May 2016 22:06:46 +0100	[thread overview]
Message-ID: <1463000807-18015-3-git-send-email-rjones@redhat.com> (raw)
In-Reply-To: <1463000807-18015-1-git-send-email-rjones@redhat.com>

Because of the risk that compilers might not emit the asm() block at
the beginning of the option ROM, check that the ROM contains the
required magic signature.

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
 scripts/signrom.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/signrom.py b/scripts/signrom.py
index 6c8b9bf..5629bca 100644
--- a/scripts/signrom.py
+++ b/scripts/signrom.py
@@ -17,7 +17,10 @@ if len(sys.argv) < 3:
 fin = open(sys.argv[1], 'rb')
 fout = open(sys.argv[2], 'wb')
 
-fin.seek(2)
+magic = fin.read(2)
+if magic != '\x55\xaa':
+    sys.exit("%s: option ROM does not begin with magic 55 aa" % sys.argv[1])
+
 size_byte = ord(fin.read(1))
 fin.seek(0)
 
-- 
2.7.4

  parent reply	other threads:[~2016-05-11 21:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11 21:06 [Qemu-devel] [PATCH v8 0/3] Add optionrom compatible with fw_cfg DMA version Richard W.M. Jones
2016-05-11 21:06 ` [Qemu-devel] [PATCH v8 1/3] scripts/signrom.py: Allow option ROM checksum script to write the size header Richard W.M. Jones
2016-05-11 21:06 ` Richard W.M. Jones [this message]
2016-05-11 21:06 ` [Qemu-devel] [PATCH v8 3/3] Add optionrom compatible with fw_cfg DMA version Richard W.M. Jones
2016-05-23 15:05   ` Paolo Bonzini
2016-05-23 15:44     ` Richard W.M. Jones
2016-05-17 14:18 ` [Qemu-devel] [PATCH v8 0/3] " Richard W.M. Jones
2016-05-17 14:35   ` Laszlo Ersek
2016-05-17 16:41     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463000807-18015-3-git-send-email-rjones@redhat.com \
    --to=rjones@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marc.mari.barcelo@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).