From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0bLP-0004wa-Tk for qemu-devel@nongnu.org; Wed, 11 May 2016 17:07:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0bLN-0004Od-Jn for qemu-devel@nongnu.org; Wed, 11 May 2016 17:06:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0bLN-0004OT-DV for qemu-devel@nongnu.org; Wed, 11 May 2016 17:06:57 -0400 From: "Richard W.M. Jones" Date: Wed, 11 May 2016 22:06:46 +0100 Message-Id: <1463000807-18015-3-git-send-email-rjones@redhat.com> In-Reply-To: <1463000807-18015-1-git-send-email-rjones@redhat.com> References: <1463000807-18015-1-git-send-email-rjones@redhat.com> Subject: [Qemu-devel] [PATCH v8 2/3] scripts/signrom.py: Check for magic in option ROMs. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefanha@gmail.com, marc.mari.barcelo@gmail.com, ehabkost@redhat.com, mst@redhat.com, kraxel@redhat.com, rth@twiddle.net, lersek@redhat.com, pbonzini@redhat.com Because of the risk that compilers might not emit the asm() block at the beginning of the option ROM, check that the ROM contains the required magic signature. Signed-off-by: Richard W.M. Jones --- scripts/signrom.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/signrom.py b/scripts/signrom.py index 6c8b9bf..5629bca 100644 --- a/scripts/signrom.py +++ b/scripts/signrom.py @@ -17,7 +17,10 @@ if len(sys.argv) < 3: fin = open(sys.argv[1], 'rb') fout = open(sys.argv[2], 'wb') -fin.seek(2) +magic = fin.read(2) +if magic != '\x55\xaa': + sys.exit("%s: option ROM does not begin with magic 55 aa" % sys.argv[1]) + size_byte = ord(fin.read(1)) fin.seek(0) -- 2.7.4